feat(retry): retry pre-response connection resets on all methods (#118)#119
Merged
Conversation
zfarrell
force-pushed
the
feat/connection-reset-retry
branch
from
8ac6a39 to
0a62a1c
Compare
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed: _retry.py correctly extends urllib3's connection-error classification so pre-response resets retry on all methods (including POST) while read timeouts and status retries stay idempotent-only. The generated configuration.py and its mustache template are kept in sync, and .openapi-generator-ignore registers the new hand-maintained module. Test coverage is thorough — bug repro, all-methods fix, bounded exhaustion, timeout gating, detector units, and pool-args wiring. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118.
Configurationnow defaults to a retry policy that transparently retries pre-response connection resets (stale pooled keep-alive connections) on every method includingPOST— safe because the reset happens before the request reaches the server, so a retry can't double-execute. Read timeouts and status retries stay idempotent-only, and an explicitretries=still overrides the default.