Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
P1 - src/api.rs:244 - Query parameter values are not URL-encoded. query_string() builds the query string with raw string interpolation. Cursor values from the API are typically base64-encoded and contain +, /, =. A + in a query string is decoded as a space by server-side parsers (application/x-www-form-urlencoded), silently corrupting the cursor. This breaks cursor-based pagination in tables::list. Action Required: URL-encode query parameter values in query_string() using urlencoding::encode.
| _ => unreachable!(), | ||
| } | ||
| crate::query::print_result(&result, format); | ||
| } |
There was a problem hiding this comment.
Suggestion: the old results::get showed [result-id: {id}] in the table footer and extracted error.message from error JSON. Both are now silently dropped. If this is intentional, no action needed — just worth confirming the UX change is expected.
|
|
||
| let resp = match self.build_request(reqwest::Method::POST, &url) | ||
| .json(body) | ||
| .send() |
There was a problem hiding this comment.
Suggestion: the doc comment says "exits on error" but this method only exits on connection failure — HTTP error responses are returned to the caller. Consider rewording to "exits on connection error, returns raw (status, body)".
| @@ -111,44 +68,10 @@ pub fn list(format: &str) { | |||
| std::process::exit(1); | |||
There was a problem hiding this comment.
Suggestion: config is loaded here to get default_id, then ApiClient::new loads it again internally. Minor double-load — not worth restructuring now, just noting it.
1 participant
No description provided.