feat(queries): Add upload url for datasets and new queries commands#23
Merged
feat(queries): Add upload url for datasets and new queries commands#23
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| if ch == '/' && i + 1 < len && chars[i + 1] == '*' { | ||
| let start = i; | ||
| i += 2; | ||
| while i + 1 < len && !(chars[i] == '*' && chars[i + 1] == '/') { |
Contributor
There was a problem hiding this comment.
Non-blocking: unterminated block comment (e.g., /* no closing) drops the final character. When the while exits with i == len - 1 (EOF), if i + 1 < len is false so i stays at len - 1, and chars[start..i] omits the last char. Fix: change the condition to while i < len and consume a whole byte at a time, or just clamp i to len before the slice:
Suggested change
| while i + 1 < len && !(chars[i] == '*' && chars[i + 1] == '/') { | |
| if i + 1 < len { i += 2; } else { i = len; } |
| }; | ||
|
|
||
| if !resp.status().is_success() { | ||
| use crossterm::style::Stylize; |
Contributor
There was a problem hiding this comment.
Non-blocking: use crossterm::style::Stylize; is already imported at the top of the module (line 2). The inner use inside this block and the one a few lines down are redundant — safe to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.