Skip to content

fix(query): fail loud on incomplete result previews #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zfarrell merged 2 commits into from
Jun 19, 2026
Merged

fix(query): fail loud on incomplete result previews #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31c6be4
fix(query): fail loud on incomplete result previews
zfarrell Jun 18, 2026
917a4be
test(query): cover table footer rendering and ApiError::message
zfarrell Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ hotdata query status <query_run_id> [-o table|json|csv]
- Long-running queries automatically fall back to async execution and return a `query_run_id`.
- Use `hotdata query status <query_run_id>` to poll for results.
- Exit codes for `query status`: `0` = succeeded, `1` = failed, `2` = still running (poll again).
- `json` output carries `truncated`, `preview_row_count`, and `total_row_count` so a consumer can detect a partial result from the body alone.
- If the server returns only a bounded preview that can't be completed (truncated and unfetchable), the CLI prints the preview, warns on stderr, and exits `3` — so pipelines break rather than silently ingest partial data.

@claude claude Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: "pipelines break rather than silently ingest partial data" is accurate for JSON consumers (the body carries truncated), but the exit-3 mechanism only breaks a shell pipeline like hotdata query ... | downstream when set -o pipefail is enabled — otherwise the pipeline's status is downstream's, not the CLI's. Worth noting that the exit-code signal requires pipefail for csv/table consumers, which have no in-body truncation marker. (not blocking)


## Query Run History

Expand Down
Loading
Loading