fix: stop using deprecated QueryResponse.row_count#158
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Correct fix. query_response_from_sdk only renders the rows it holds in both reachable cases (non-truncated full result, and truncated-without-result_id preview), so deriving the count from rows.len() matches what the user sees. Truncated-with-result_id follows to Arrow and never hits this path. Tests cover the branches.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline query path read the deprecated SDK
QueryResponse.row_countfield; it now derives the displayed count fromrows.len()(the rows actually rendered), which is correct whether the response is whole or a non-fetchable truncated preview. Otherrow_countusages (QueryRunInfo,/resultslist, load-table) are separate non-deprecated fields and unchanged.