Skip to content

[Aikido] AI Fix for Path traversal attack possible #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aikido-autofix wants to merge 1 commit into from
Closed

[Aikido] AI Fix for Path traversal attack possible #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/keys.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,22 @@ impl DatasetLayout {

let mut running_total = 0u64;
for &path in local_paths {
let file_name = Path::new(path)
// Prevent path traversal attacks by rejecting paths containing '..'.
let p = Path::new(path);
if p.components().any(|c| c == std::path::Component::ParentDir) {
return Err(DataFusionError::Execution(format!(
"Invalid input: {}",
p.display()
)));
}

let file_name = p
.file_name()
.and_then(|n| n.to_str())
.ok_or_else(|| DataFusionError::Execution(format!("invalid path: {path}")))?;
file_keys.push(format!("{key_prefix}{file_name}"));

let f = fs::File::open(path)
let f = fs::File::open(p)
.map_err(|e| DataFusionError::Execution(format!("open {path}: {e}")))?;
let builder = ParquetRecordBatchReaderBuilder::try_new(f)
.map_err(|e| DataFusionError::Execution(format!("read footer {path}: {e}")))?;
Expand Down
Loading