fix(sqlite): WAL checkpoint + add view_index for mmap loading#11
Merged
anoop-narang merged 3 commits intomainfrom Mar 23, 2026
Merged
fix(sqlite): WAL checkpoint + add view_index for mmap loading#11anoop-narang merged 3 commits intomainfrom
anoop-narang merged 3 commits intomainfrom
Conversation
Data written during build may only exist in the WAL file. Without an explicit checkpoint, the data can be lost if the process exits before SQLite performs a passive checkpoint. This caused empty query results when reloading the .db file after an engine restart.
view_index uses mmap instead of loading the full index into RAM, keeping resident memory proportional to the working set. Prefer this for the reload-from-disk path where the index file is already local.
Covers the case where the SELECT list contains only the distance UDF and no base table columns, with bare and qualified table references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open_or_build— data written during build was only in the WAL file and could be lost on process restart, causing empty SQLite query results when reloading the .dbview_indexonUSearchIndexConfig— memory-maps the index file instead of loading into RAM, keeping resident memory proportional to working set rather than full index sizeTest plan
cargo clippy -- -D warningsclean