feat: add hc-static-site to pulumi using config copied from docs-pages#47
Open
feat: add hc-static-site to pulumi using config copied from docs-pages#47
Conversation
🍹
|
|
✔️ 1bad2fc...42b3b62 - Conventional commits check succeeded. |
jost-s
reviewed
Jul 3, 2025
| HasProjects: pulumi.Bool(true), | ||
| HasWiki: pulumi.Bool(false), | ||
| VulnerabilityAlerts: pulumi.Bool(false), | ||
| AllowAutoMerge: pulumi.Bool(false), |
Contributor
There was a problem hiding this comment.
I think this is useful to enable.
Member
There was a problem hiding this comment.
For all of these, you have to turn these on for the import to work and then remove them again later. Pulumi will only import an existing resource if the state matches exactly
| HasWiki: pulumi.Bool(false), | ||
| VulnerabilityAlerts: pulumi.Bool(false), | ||
| AllowAutoMerge: pulumi.Bool(false), | ||
| DeleteBranchOnMerge: pulumi.Bool(false), |
Contributor
There was a problem hiding this comment.
This is highly useful to avoid merged branches to linger on in the repo.
Comment on lines
+543
to
+545
| AllowSquashMerge: pulumi.Bool(false), | ||
| AllowRebaseMerge: pulumi.Bool(false), | ||
| AllowMergeCommit: pulumi.Bool(false), |
Contributor
There was a problem hiding this comment.
Mmh, if they're all disallowed, I wonder how branches should be merged. Usually we have squash and rebase merges.
Member
|
I'd help with this PR but I don't have permissions on the repository to apply the import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets the Holochain website under Pulumi. The main goal is to make it so we can bypass cocogitto-bot's ability to block a PR.