Skip to content

docs(v2): describe Money wrapper shape on partner-api responses#251

Closed
samuelwisemanhx wants to merge 3 commits intomasterfrom
feat/prices-as-floats
Closed

docs(v2): describe Money wrapper shape on partner-api responses#251
samuelwisemanhx wants to merge 3 commits intomasterfrom
feat/prices-as-floats

Conversation

@samuelwisemanhx
Copy link
Copy Markdown
Contributor

What does this PR do? (please provide any background)

Updates the Currency and Pricing section of site/partner/v2/api-endpoint-navigation-guide.md to describe the new { amount_major, currency } Money wrapper shape that partner-api v2 emits for every money-bearing field. Removes the previous claim that values are in minor currency units; adds a worked example and explains the optional-money null contract.

Pairs with holidayextras/partner-api#471 (the actual response-shape change).

Any tech debt?

None added.

Screenshots / Screencast

n/a — markdown change. Diff visible in the file change tab.

By approving a review you are confirming you have...

  • Witnessed the work behaving as expected (this could be on the author's machine or screencast).
  • Checked for coding anti-patterns.
  • Checked for appropriate test coverage.
  • Checked all the tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant