Add close-path replication reschedule coverage#809
Open
marcus-pousette-hp wants to merge 13 commits into
Open
Conversation
marcus-pousette-hp
force-pushed
the
fix/replicator-close-update
branch
from
7d01666 to
1d442e7
Compare
lejeunerenard
requested changes
May 15, 2026
Contributor
lejeunerenard
left a comment
lejeunerenard
left a comment
There was a problem hiding this comment.
Good reproductions of the two test scenarios I mentioned out of band. With changes they will be less brittle & clearer.
I think though the fixes for when we call .updateAll() aren't netting us less work now that we have tests to show how it reschedules work potentially (ie the ranges test).
| const cores = [] | ||
| const clones = [] | ||
|
|
||
| for (let i = 0; i < 4; i++) { |
Contributor
There was a problem hiding this comment.
This should test multiple peers for one core, not multiple core pairs for two peers. With pairs of cores between two peers, the number of peers being checked on channel close are 0 because there's only one peer as you assert below.
marcus-pousette-hp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for peer-close scheduling paths:
This PR is test-only. The idle-close updateAll() optimization was moved to a follow-up branch.