Swap classloader to Class.forName().getPackage()#88
Open
gorbit99 wants to merge 1 commit intohoijui:masterfrom
Open
Swap classloader to Class.forName().getPackage()#88gorbit99 wants to merge 1 commit intohoijui:masterfrom
gorbit99 wants to merge 1 commit intohoijui:masterfrom
Conversation
Collaborator
|
Didn't test this on Android myself, but the change seems pretty straight forward and the reasoning seems sound. I vote to merge it even when there is nobody (else) available to test this on Android. @gorbit99 Does the whole library work when this change is applied? Would you be interested in testing more Android specific patches in the future? |
Author
|
@Jurrie I haven't done a lot of testing past seeing that the error has disappeared and at least this part of the code was back to working. I don't really test things on android, I just happened to have android studio open after investigating a crash caused by this issue and wanted to fix it for the future. I wouldn't make for a good Android tester. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to fix #75 and #87
Since getDefinedPackage is not available on android, I just replaced it with the same logic that was used for java.awt. Since java.lang and java.util should always be present and loaded, I elected to just ignore the ClassNotFoundException.