ARCPOC-1403: BE - Report Fees: Allow other location only filter#502
Closed
github-actions[bot] wants to merge 1 commit into
Closed
ARCPOC-1403: BE - Report Fees: Allow other location only filter#502github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Jira: https://tools.hmcts.net/jira/browse/ARCPOC-1403 Generated by Codex self-hosted runner for ARCPOC-1403.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See ARCPOC-1403
Change description
Implements Jira issue ARCPOC-1403: BE - Report Fees: Allow other location only filter
Codex ran on the Azure AKS self-hosted runner scale set using the Jira issue context. See the Codex final message below for the implementation summary.
Testing done
Codex may run targeted checks during generation. This workflow verifies the generated patch in a separate no-write job before the trusted publish job opens the pull request. See the Codex final message below and workflow logs for details.
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist
Codex Final Message
Implemented ARCPOC-1403.
Summary:
otherLocationDescriptionon its own.courtLocationCodemutually exclusive withcjaCodeandotherLocationDescription.Verification:
git diff --check-> passed../gradlew test --tests uk.gov.hmcts.appregister.report.validator.ReportLocationValidatorTest-> failed before tests: default/home/runner/.gradlewrapper lock path is read-only.GRADLE_USER_HOME=/tmp/codex-gradle ./gradlew --no-daemon test --tests uk.gov.hmcts.appregister.report.validator.ReportLocationValidatorTest-> failed before tests: Gradle could not start because the runner blocks network interface access needed by Gradle’s file lock listener (Operation not permitted).Codex Repair Attempt 1
Repaired the failed patch by updating the stale Workload integration test to match the new shared location rules.
otherLocationDescriptionwithout CJA now creates and downloads a Workload CSV, and the test asserts the other-location filter includes the matching row and excludes the non-matching row.Checks run:
git diff --checkpassed.find . -name '*.appregtmp' -printreturned no files.java.net.SocketException: Operation not permitted.