Skip to content

ARCPOC-1403: BE - Report Fees: Allow other location only filter#502

Closed
github-actions[bot] wants to merge 1 commit into
masterfrom
codex/arcpoc-1403-26641053996-1
Closed

ARCPOC-1403: BE - Report Fees: Allow other location only filter#502
github-actions[bot] wants to merge 1 commit into
masterfrom
codex/arcpoc-1403-26641053996-1

Conversation

@github-actions
Copy link
Copy Markdown

Jira link

See ARCPOC-1403

Change description

Implements Jira issue ARCPOC-1403: BE - Report Fees: Allow other location only filter

Codex ran on the Azure AKS self-hosted runner scale set using the Jira issue context. See the Codex final message below for the implementation summary.

Testing done

Codex may run targeted checks during generation. This workflow verifies the generated patch in a separate no-write job before the trusted publish job opens the pull request. See the Codex final message below and workflow logs for details.

Security Vulnerability Assessment

CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?

  • Yes
  • No

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

Codex Final Message

Implemented ARCPOC-1403.

Summary:

  • Updated report location validation to allow otherLocationDescription on its own.
  • Kept courtLocationCode mutually exclusive with cjaCode and otherLocationDescription.
  • Updated RPT-4 messaging to reflect the actual invalid combination.
  • Updated report OpenAPI source descriptions for the new valid combinations.
  • Added/updated tests, including a fees report integration case proving other-location-only filtering creates a job and returns only matching CSV rows.

Verification:

  • git diff --check -> passed.
  • ./gradlew test --tests uk.gov.hmcts.appregister.report.validator.ReportLocationValidatorTest -> failed before tests: default /home/runner/.gradle wrapper lock path is read-only.
  • GRADLE_USER_HOME=/tmp/codex-gradle ./gradlew --no-daemon test --tests uk.gov.hmcts.appregister.report.validator.ReportLocationValidatorTest -> failed before tests: Gradle could not start because the runner blocks network interface access needed by Gradle’s file lock listener (Operation not permitted).

Codex Repair Attempt 1

Repaired the failed patch by updating the stale Workload integration test to match the new shared location rules. otherLocationDescription without CJA now creates and downloads a Workload CSV, and the test asserts the other-location filter includes the matching row and excludes the non-matching row.

Checks run:

  • git diff --check passed.
  • find . -name '*.appregtmp' -print returned no files.
  • Attempted the targeted Gradle integration test, but Gradle cannot start inside this sandbox because its file-lock socket setup is blocked with java.net.SocketException: Operation not permitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant