ARCPOC-1411: BE - Activity Audit Report - Body with unsupported request fields passes#501
Open
github-actions[bot] wants to merge 2 commits into
Open
ARCPOC-1411: BE - Activity Audit Report - Body with unsupported request fields passes#501github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
Jira: https://tools.hmcts.net/jira/browse/ARCPOC-1411 Generated by Codex self-hosted runner for ARCPOC-1411.
zachealy113
reviewed
May 29, 2026
Contributor
zachealy113
left a comment
There was a problem hiding this comment.
/codex-review
Please make a small safe improvement: add an assertion to the unsupported activity-audit field regression test that confirms no report job is created when the request is rejected with 400.
Feedback: #501 (review) Generated by Codex self-hosted runner.
Author
|
Codex pushed an update for review feedback from @zachealy113. Feedback: #501 (review) Commit: 200aded Codex final message: Implemented the review feedback in ReportingControllerPostTest.java. The unsupported activity-audit field regression test now records the existing Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See ARCPOC-1411
Change description
Implements Jira issue ARCPOC-1411: BE - Activity Audit Report - Body with unsupported request fields passes
Codex ran on the Azure AKS self-hosted runner scale set using the Jira issue context. See the Codex final message below for the implementation summary.
Testing done
Codex may run targeted checks during generation. This workflow verifies the generated patch in a separate no-write job before the trusted publish job opens the pull request. See the Codex final message below and workflow logs for details.
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist
Codex Final Message
Implemented ARCPOC-1411.
Summary:
ActivityAuditFilterRequestBodyAdviceto reject unsupported top-level JSON fields forActivityAuditFilterDtobefore the report job is created.AppRegExceptionHandlerto return a clear 400 detail:Unsupported request field: <field>.POST /reports/activity-audit/jobswith unsupportedcourtCode.Verification:
git diff --check- passed.GRADLE_DAEMON_BIND_ADDRESS=127.0.0.1 GRADLE_USER_HOME=/tmp/gradle /home/runner/.gradle/wrapper/dists/gradle-9.5.1-all/3mo7ofu40rhxhyro6vr9xd6jp/gradle-9.5.1/bin/gradle --no-daemon test --tests 'uk.gov.hmcts.appregister.report.controller.ActivityAuditFilterRequestBodyAdviceTest' --tests 'uk.gov.hmcts.appregister.common.exception.AppRegExceptionHandlerTest'- failed before test execution because Gradle could not start in this runner:java.net.SocketException: Operation not permittedfromFileLockContentionHandler.