fix(bash): highlight command line flags/options fixes #4288#4367
Open
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Open
fix(bash): highlight command line flags/options fixes #4288#4367KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
KJyang-0114 wants to merge 1 commit intohighlightjs:mainfrom
Conversation
Add highlighting for command line flags like --option and -o in bash. This fixes inconsistent highlighting where only some flags were highlighted as built_in while others had no highlighting. Fixes highlightjs#4288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #4288 where command line flags/options like
--project,--deployment-package, etc. were not being consistently highlighted in bash code blocks.The Problem
The issue reported that in bash commands with multiple flags:
hljs-built_inThe Fix
Added a new
COMMAND_FLAGSpattern that highlights:--option-name-oThese are highlighted with the
hljs-attrclass for better visibility.Testing
Before:
After:
Closes #4288