Skip to content

feat: Add Workflow Documentation Guide#1772

Merged
exploreriii merged 2 commits intohiero-ledger:mainfrom
jona42-ui:docs/workflow-documentation-guide
Feb 21, 2026
Merged

feat: Add Workflow Documentation Guide#1772
exploreriii merged 2 commits intohiero-ledger:mainfrom
jona42-ui:docs/workflow-documentation-guide

Conversation

@jona42-ui
Copy link
Copy Markdown
Contributor

@jona42-ui jona42-ui commented Feb 10, 2026

Description:

This commit adds a comprehensive guide for documenting GitHub workflows and automation scripts . The guide covers best practices for:

  • Writing clear header blocks with PURPOSE, TRIGGER, MAJOR RULES, and RELATED DOCS
  • Creating informative docstrings explaining intent, assumptions, side effects, and edge cases
  • Making exit reasons obvious with clear comments
  • Using descriptive, action-oriented naming conventions

The guide includes practical examples in Javascript, a documentation checklist, and links to related documentation.

Related issue(s):

Fixes #1745

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copilot AI review requested due to automatic review settings February 10, 2026 10:12
@jona42-ui jona42-ui requested review from a team as code owners February 10, 2026 10:12
@github-actions
Copy link
Copy Markdown

Hi @jona42-ui, this is **LinkBot** 👋

Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy.

🚨 This pull request does not have an issue linked.

Please link an issue using the following format:

📖 Guide:
docs/sdk_developers/how_to_link_issues.md

If no issue exists yet, please create one:
docs/sdk_developers/creating_issues.md

Thanks!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

Walkthrough

Adds a new Workflow Documentation Guide at docs/github/04_workflow_documentation.md and a corresponding changelog entry in CHANGELOG.md. The guide prescribes header structure, docstring standards, exit-reason comments, naming conventions, examples, and a documentation checklist.

Changes

Cohort / File(s) Summary
Documentation guide & changelog
CHANGELOG.md, docs/github/04_workflow_documentation.md
Adds a new documentation file describing how to document GitHub workflows and automation scripts (header blocks, docstring conventions, exit-reason comments, naming guidance, examples, and a checklist). Updates changelog with the new documentation entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a workflow documentation guide.
Description check ✅ Passed The description is related to the changeset, covering best practices for documenting workflows and linking to the related issue.
Linked Issues check ✅ Passed The PR comprehensively addresses issue #1745 requirements: includes top-of-file header guidance (PURPOSE, TRIGGER, MAJOR RULES, RELATED DOCS), documents docstring best practices (intent, assumptions, side effects, edge cases), emphasizes explicit exit reasons, promotes clear naming conventions, includes practical examples, and adds a changelog entry.
Out of Scope Changes check ✅ Passed All changes are in scope: the new documentation file and changelog entry directly fulfill issue #1745 objectives with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new documentation guide describing best practices for documenting GitHub workflows and automation scripts in the Hiero Python SDK, addressing the need captured in issue #1745.

Changes:

  • Added a new workflow documentation guide under docs/github/.
  • Added a changelog entry documenting the new guide.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
docs/github/04_workflow_documentation.md Introduces a workflow documentation best-practices guide with examples, checklist, and related links.
CHANGELOG.md Records the addition of the workflow documentation guide under the Documentation section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md
@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from 1d26760 to 6d25665 Compare February 10, 2026 12:17
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread docs/github/04_workflow_documentation.md Outdated
Copy link
Copy Markdown
Contributor

@aceppaluni aceppaluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jona42-ui Thank you for your contribution!

A few tweaks:

  1. The check for the PR title is failing. To correct this change to feat: Add Workflow Documentation Guide
  2. Please take a look at the AI/Coderabbit suggestions. There is a mention of unused imports and correct the description.

If you have questions please reach out. We're happy to help!

@jona42-ui jona42-ui changed the title docs: add workflow documentation guide feat: Add Workflow Documentation Guide Feb 10, 2026
@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from ec9da01 to 825df33 Compare February 10, 2026 16:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1772   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         141      141           
  Lines        9118     9118           
=======================================
  Hits         8507     8507           
  Misses        611      611           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aceppaluni
aceppaluni previously approved these changes Feb 10, 2026
Copy link
Copy Markdown
Contributor

@aceppaluni aceppaluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jona42-ui Great work, thank you for the corrections!

LGTM!

Note

You can ignore the failing check.
This happens when the integration tests take longer then 7 minutes to run.

Copy link
Copy Markdown
Contributor

@MonaaEid MonaaEid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the documentation doesn’t fully meet the issue requirements, so please review them carefully... Thank you!

Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
@exploreriii exploreriii marked this pull request as draft February 10, 2026 19:26
@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from 2a10ac9 to bf71ea7 Compare February 11, 2026 08:39
@github-actions
Copy link
Copy Markdown

Hello, this is the OfficeHourBot.

This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC).

This session provides an opportunity to ask questions regarding this Pull Request.

Details:

Disclaimer: This is an automated reminder. Please verify the schedule here for any changes.

From,
The Python SDK Team

Copy link
Copy Markdown
Contributor

@MonaaEid MonaaEid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the workflows and scripts Scripts,
Workflows
I think the docs should describe what we already use.

Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
@MonaaEid
Copy link
Copy Markdown
Contributor

Hi @jona42-ui, if you need help with that or have any questions, feel free to reach out. ...we're happy to help, thank you!

@exploreriii exploreriii added the dev: stale development is currently inactive - please reactivate label Feb 15, 2026
@jona42-ui
Copy link
Copy Markdown
Contributor Author

jona42-ui commented Feb 18, 2026

Please take a look at the workflows and scripts Scripts, Workflows I think the docs should describe what we already use.

whatever you are seeing in the yaml example file is the explanation(more less a comment) that should first be written and adopted in all workflow files, it does not mean its pure yaml syntax, but a guidance to the reader what that worflow is meant for, i guess that's the main intent of the issue. you can correct me if i am wrong

@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from b42f48d to 1aaca9f Compare February 18, 2026 04:59
@jona42-ui
Copy link
Copy Markdown
Contributor Author

I think the docs should describe what we already use.

Yes partially the current workflows don't enforce explaining the intent of the workflow/script, they simply outright the yaml or python syntax, which is not what the current issue advocates for according to the issue description.

@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from 9254db8 to ab6f627 Compare February 18, 2026 05:10
@exploreriii
Copy link
Copy Markdown
Contributor

Yes, the current workflows are V1, would very much like to raise the level a bit with these documents on what the future should be :)

Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md Outdated
Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md Outdated
@exploreriii exploreriii removed the dev: stale development is currently inactive - please reactivate label Feb 18, 2026
@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from ab6f627 to f623602 Compare February 19, 2026 18:41
Copy link
Copy Markdown
Contributor

@exploreriii exploreriii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move line 188 to line 31 ish in your changelog, then great to go! Thank you so much

Signed-off-by: jona42-ui <jonathanthembo123@gmail.com>
@jona42-ui jona42-ui force-pushed the docs/workflow-documentation-guide branch from eae6f08 to 17e5d37 Compare February 21, 2026 05:35
@github-actions
Copy link
Copy Markdown

Hi, this is MergeConflictBot.
Your pull request cannot be merged because it contains merge conflicts.

Please resolve these conflicts locally and push the changes.

Quick Fix for CHANGELOG.md Conflicts

If your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:

  1. Click on the "Resolve conflicts" button in the PR
  2. Accept both changes (keep both changelog entries)
  3. Click "Mark as resolved"
  4. Commit the merge

For all other merge conflicts, please read:

Thank you for contributing!

Signed-off-by: Thembo Jonathan <jonathanthembo123@gmail.com>
@exploreriii exploreriii marked this pull request as ready for review February 21, 2026 22:26
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Comment thread CHANGELOG.md
Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md
Comment thread docs/github/04_workflow_documentation.md
@github-actions
Copy link
Copy Markdown

Hi, this is WorkflowBot.
Your pull request cannot be merged as it is not passing all our workflow checks.
Please click on each check to review the logs and resolve issues so all checks pass.
To help you:

@exploreriii exploreriii merged commit a428a1b into hiero-ledger:main Feb 21, 2026
27 of 28 checks passed
@exploreriii
Copy link
Copy Markdown
Contributor

Great work @jona42-ui thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Intermediate]: Create docs/github/04_workflow_documentation.md

5 participants