feat: Add Workflow Documentation Guide#1772
Conversation
|
Hi @jona42-ui, this is **LinkBot** 👋
Linking pull requests to issues helps us significantly with reviewing pull requests and keeping the repository healthy. 🚨 This pull request does not have an issue linked. Please link an issue using the following format: 📖 Guide: If no issue exists yet, please create one: Thanks! |
WalkthroughAdds a new Workflow Documentation Guide at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a new documentation guide describing best practices for documenting GitHub workflows and automation scripts in the Hiero Python SDK, addressing the need captured in issue #1745.
Changes:
- Added a new workflow documentation guide under
docs/github/. - Added a changelog entry documenting the new guide.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/github/04_workflow_documentation.md | Introduces a workflow documentation best-practices guide with examples, checklist, and related links. |
| CHANGELOG.md | Records the addition of the workflow documentation guide under the Documentation section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1d26760 to
6d25665
Compare
aceppaluni
left a comment
There was a problem hiding this comment.
@jona42-ui Thank you for your contribution!
A few tweaks:
- The check for the PR title is failing. To correct this change to
feat: Add Workflow Documentation Guide - Please take a look at the AI/Coderabbit suggestions. There is a mention of unused imports and correct the description.
If you have questions please reach out. We're happy to help!
ec9da01 to
825df33
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1772 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 141 141
Lines 9118 9118
=======================================
Hits 8507 8507
Misses 611 611 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@jona42-ui Great work, thank you for the corrections!
LGTM!
Note
You can ignore the failing check.
This happens when the integration tests take longer then 7 minutes to run.
MonaaEid
left a comment
There was a problem hiding this comment.
It seems the documentation doesn’t fully meet the issue requirements, so please review them carefully... Thank you!
2a10ac9 to
bf71ea7
Compare
|
Hello, this is the OfficeHourBot. This is a reminder that the Hiero Python SDK Office Hours are scheduled in approximately 4 hours (14:00 UTC). This session provides an opportunity to ask questions regarding this Pull Request. Details:
Disclaimer: This is an automated reminder. Please verify the schedule here for any changes. From, |
|
Hi @jona42-ui, if you need help with that or have any questions, feel free to reach out. ...we're happy to help, thank you! |
whatever you are seeing in the yaml example file is the explanation(more less a comment) that should first be written and adopted in all workflow files, it does not mean its pure yaml syntax, but a guidance to the reader what that worflow is meant for, i guess that's the main intent of the issue. you can correct me if i am wrong |
b42f48d to
1aaca9f
Compare
Yes partially the current workflows don't enforce explaining the intent of the workflow/script, they simply outright the yaml or python syntax, which is not what the current issue advocates for according to the issue description. |
9254db8 to
ab6f627
Compare
|
Yes, the current workflows are V1, would very much like to raise the level a bit with these documents on what the future should be :) |
ab6f627 to
f623602
Compare
exploreriii
left a comment
There was a problem hiding this comment.
please move line 188 to line 31 ish in your changelog, then great to go! Thank you so much
Signed-off-by: jona42-ui <jonathanthembo123@gmail.com>
eae6f08 to
17e5d37
Compare
|
Hi, this is MergeConflictBot. Please resolve these conflicts locally and push the changes. Quick Fix for CHANGELOG.md ConflictsIf your conflict is only in CHANGELOG.md, you can resolve it easily using the GitHub web editor:
For all other merge conflicts, please read: Thank you for contributing! |
Signed-off-by: Thembo Jonathan <jonathanthembo123@gmail.com>
|
Hi, this is WorkflowBot.
|
|
Great work @jona42-ui thank you! |
Description:
This commit adds a comprehensive guide for documenting GitHub workflows and automation scripts . The guide covers best practices for:
The guide includes practical examples in Javascript, a documentation checklist, and links to related documentation.
Related issue(s):
Fixes #1745
Notes for reviewer:
Checklist