Update quantity repr#1579
Open
jules-ch wants to merge 2 commits intohgrecco:masterfrom
Open
Conversation
3e393ff to
5cf654c
Compare
Collaborator
|
any reason this wasn't merged for the last releases? |
CodSpeed Performance ReportMerging #1579 will not alter performanceComparing Summary
|
Collaborator
Author
|
Gonna rebase and I think we can merge this. |
- Update CHANGES - Add test for repr - Update repr function to include magnitude repr & units
9eeeb2a to
4fdaa41
Compare
4fdaa41 to
9c082fa
Compare
Collaborator
Author
|
is there a reason why we are using only 6 decimals for float. |
Collaborator
|
not that I am aware of. what would be best for the repr? I'd just use the repr of the float |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Quantity repr #1495
Executed
pre-commit run --all-fileswith no errorsThe change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file
Update CHANGES
Add test for repr
Update repr function to include magnitude repr & units