fix(producer): align frame coverage with extraction rounding#2770
Open
jrusso1020 wants to merge 1 commit into
Open
fix(producer): align frame coverage with extraction rounding#2770jrusso1020 wants to merge 1 commit into
jrusso1020 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
-vf fps=<fps>: nearest output-frame boundary-fps_mode cfr -r <fps>: ceilWhy
The coverage gate universally used
ceil(duration * fps), but FFmpeg's CFR fps filter rounds to the nearest boundary. This made successfully extracted short CFR clips such as 0.616666s at 30 fps look truncated (18 captured vs 19 expected).In the dashboard window, 124 of 335 video-coverage failures were exactly one frame short. Historical logs do not include
isVFR, so that is the maximum addressable cohort rather than a guaranteed reduction. Zero-frame and materially truncated extraction failures remain fail-closed.Safety
Test
bunx vitest run packages/producer/src/services/render/videoFrameCoverage.test.ts(28 passed)bun run --filter @hyperframes/producer typecheckbunx oxlint ...videoFrameCoverage.ts ...videoFrameCoverage.test.tsbunx oxfmt --check ...videoFrameCoverage.ts ...videoFrameCoverage.test.tsbunx fallow audit --base origin/main --fail-on-issues