fix(render): normalize external SVG namespaces#2734
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
High-quality renders silently produced a visually divergent best-effort MP4 when an external SVG omitted its root
xmlns. Validation and snapshots passed, but capture emittedFrameCapture:media_load_failedand still exited 0.Originating source mapping: this PR addresses the authorized report at https://slack.com/archives/C0BGC335AQY/p1784694361653429 (candidate #1520).
Fix
Verification
bun test packages/producer/src/services/fileServer.test.ts— 49 passedbunx vitest run packages/core/src/compiler/htmlBundler.test.ts— 45 passedbun run build— passedmedia_load_failedor correctness warning8940560844427cd94a71d8cb914d0b5c21c63ee26ffe0f51270d7be2d61f38a8, SSIM All1.000000Numeric-ID lint and TTS/custom-score behavior are intentionally untouched.