fix(cli): stop download tmp cleanup racing the write stream open#2722
Open
vanceingalls wants to merge 1 commit into
Open
fix(cli): stop download tmp cleanup racing the write stream open#2722vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloadFilehad two independent cleanup+reject paths racing each other on failure:request.on("error")→ unlink.tmp+ rejectpipeline(res, file).catch→ unlink.tmp+ rejectcreateWriteStream(tmp)opens asynchronously — on a timeout, path 1 can unlink and reject before the file even exists; the stream's open then creates.tmpafter cleanup already ran. In CI this flakeddownload.test.ts > "rejects an idle response and removes the partial file"(expected true to be false— surfaced on PR #2681's Test job, unrelated to that PR's diff); in the wild it strands partial.tmpfiles in the model cache dir.Fix
Once the 200 branch hands the response to
pipeline(), the pipeline's catch owns cleanup and rejection — it settles only after the write stream has closed, so the.tmpfile provably exists (or never will) when it unlinks. The request error handler stands down in that window, but stashes its error so the precise failure message (e.g.Download timed out after 30000ms) survives — destroying the request can otherwise reject the pipeline with a generic premature-close.Pre-200 failures (connection refused, redirect errors) keep the original request-error path — no pipeline exists to own cleanup there.
Test plan
download.test.ts10/10 consecutive passes (was intermittent)tsc --noEmitcleanoxlint+oxfmt --checkcleanPre-existing since #2415 — not introduced by any open PR; fixing it deflakes every PR's Test job.
🤖 Generated with Claude Code