fix(studio): keyframe stability + modular border-radius editor#1217
Open
miguel-heygen wants to merge 6 commits into
Open
fix(studio): keyframe stability + modular border-radius editor#1217miguel-heygen wants to merge 6 commits into
miguel-heygen wants to merge 6 commits into
Conversation
Fallow audit reportFound 22 findings. Duplication (11)
Health (11)
Generated by fallow. |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
…ache on deletion Two stability fixes for the keyframe editing flow: 1. Code editor refreshes after GSAP script mutations via onFileContentChanged callback that syncs result.after to editingFile state. 2. Keyframe cache clears on deletion: commitMutation removes cache entries for elements without keyframes, usePopulateKeyframeCacheForFile clears stale entries before repopulating. Also fixes pre-existing typecheck: handleGsapMaterializeKeyframes optional in TimelineToolbar DomEditSessionSlice.
Add border-top-left-radius, border-top-right-radius, border-bottom-right-radius, border-bottom-left-radius to CURATED_STYLE_PROPERTIES. The Radius section auto-detects uniform vs per-corner mode: single slider when all corners match, 4 MetricFields (TL/TR/BR/BL) when they differ.
Figma-style SVG corner picker showing a rounded rectangle preview with 4 corner handles. Link/unlink toggle switches between uniform mode (single field) and per-corner mode (4 fields TL/TR/BL/BR).
When GSAP animates borderRadius, read the per-corner computed styles from the iframe element and pass them to the BorderRadiusEditor. The design panel now shows interpolated border-radius values as the playhead moves through GSAP keyframes.
When the code editor saves changes (via refreshKey), the GSAP keyframe cache was not invalidated because code-tab edits bypass commitMutation. Watch refreshKey changes and bump gsapCacheVersion so timeline diamonds clear when keyframes are manually removed in the code editor.
miguel-heygen
force-pushed
the
fix/keyframe-stability-border-radius
branch
from
84d75b7 to
60573ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan