fix(@tanstack/query-core): skip SSE endpoints in createMutationOptions#3470
Draft
fix(@tanstack/query-core): skip SSE endpoints in createMutationOptions#3470
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
…ndpoints Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken mutation for SSE endpoints in React Query
fix(@tanstack/query-core): skip SSE endpoints in createMutationOptions
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createMutationOptionswas missing thehasOperationSseguard thatcreateQueryOptionsandcreateUseQueryalready have, causing SSE POST endpoints to generate a brokenmutationFnthat destructures{ data }fromServerSentEventsResult(which hasstream, notdata).Changes
mutationOptions.ts: Add early-return guardif (hasOperationSse({ operation })) return— mirrors the existing pattern inqueryOptions.tsanduseQuery.tsspecs/3.1.x/sse-post.yaml: Minimal spec with a POST SSE endpoint + a GET JSON endpoint to drive the new test3.1.x.test.ts+ snapshots: Test case confirming the SSE POST endpoint produces no entry in@tanstack/react-query.gen.tswhile the GET endpoint still generatesqueryOptionsnormallyWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/openapi-ts/openapi-ts/examples/openapi-ts-tanstack-angular-query-experimental/node_modules/.bin/../@angular/cli/bin/ng.js build bash --no�� esm(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.