fix: logs.file: false in config file ignored when using CLI#3469
fix: logs.file: false in config file ignored when using CLI#3469
logs.file: false in config file ignored when using CLI#3469Conversation
|
|
🦋 Changeset detectedLatest commit: 9e3d347 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: mrlubos <12529395+mrlubos@users.noreply.github.com>
logs.file: false in config file ignored when using CLI
|
Leaping into action... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
=======================================
Coverage 40.11% 40.11%
=======================================
Files 478 478
Lines 17488 17488
Branches 5294 5300 +6
=======================================
Hits 7016 7016
Misses 8425 8425
Partials 2047 2047
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@hey-api/codegen-core
@hey-api/json-schema-ref-parser
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/shared
@hey-api/types
@hey-api/vite-plugin
commit: |

Commander.js's
--no-log-filenegation option always populateslogFile(defaulting totruewhen not explicitly passed).cliToConfigunconditionally spreadfile: cli.logFileinto the config, so the CLI always sent{ logs: { file: true } }tocreateClient.mergeConfigsthen overwrote the config file's{ file: false }with the CLI's{ file: true }.Changes
cli/adapter.ts: Change condition fromcli.logFile !== undefinedtocli.logFile === false— only injectfile: falsewhen--no-log-fileis explicitly passed; omitfileentirely otherwise, letting config file values take effect__tests__/cli.test.ts: Update tests to reflect that default CLI invocations no longer injectfile: trueinto the logs configOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.