Skip to content

fix(dev-tool): show 'Welcome back' instead of 'Anonymous' for unnamed users #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aadesh18 wants to merge 2 commits into
base: dev
Choose a base branch
from
+3 −1
Open

fix(dev-tool): show 'Welcome back' instead of 'Anonymous' for unnamed users #1507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03aed0e
fix(dev-tool): show 'Welcome back' instead of 'Anonymous' for unnamed…
aadesh18 May 27, 2026
08521c0
Apply suggestion from @coderabbitai[bot]
aadesh18 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/template/src/dev-tool/dev-tool-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,9 @@ function createOverviewTab(app: StackClientApp<true>): TabResult {
} else {
avatar.textContent = initials;
}
userName.textContent = currentUser.displayName || 'Anonymous';
userName.textContent = currentUser.isAnonymous
? 'Anonymous'
: (currentUser.displayName ?? 'Welcome back');
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Using ?? instead of || here means an empty-string displayName will render as blank text, while the avatar initials (computed with || two lines above) will fall through to primaryEmail. If the goal is to treat empty strings as "no name", keep || for consistency, or switch both to ??.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At packages/template/src/dev-tool/dev-tool-core.ts, line 951:

<comment>Using `??` instead of `||` here means an empty-string `displayName` will render as blank text, while the avatar initials (computed with `||` two lines above) will fall through to `primaryEmail`. If the goal is to treat empty strings as "no name", keep `||` for consistency, or switch both to `??`.</comment>

<file context>
@@ -948,7 +948,7 @@ function createOverviewTab(app: StackClientApp<true>): TabResult {
         userName.textContent = currentUser.isAnonymous
           ? 'Anonymous'
-          : (currentUser.displayName || 'Welcome back');
+          : (currentUser.displayName ?? 'Welcome back');
         userEmail.textContent = currentUser.primaryEmail || 'No email';
         authIndicator.style.display = '';
</file context>
Suggested change
: (currentUser.displayName ?? 'Welcome back');
: (currentUser.displayName || 'Welcome back');
Fix with Cubic

userEmail.textContent = currentUser.primaryEmail || 'No email';
authIndicator.style.display = '';
} else {
Expand Down
Loading