feat: allow chart deployment strategy#1190
Open
siryur wants to merge 1 commit intohetznercloud:mainfrom
Open
Conversation
siryur
changed the title
lukasmetzner
requested changes
Mar 18, 2026
| app.kubernetes.io/name: '{{ include "hcloud-cloud-controller-manager.name" $ }}' | ||
| app.kubernetes.io/instance: "{{ $.Release.Name }}" | ||
|
|
||
| # strategy: |
Contributor
There was a problem hiding this comment.
Suggested change
| # strategy: | |
| # Deployment strategy for the hccm Pod. | |
| # See https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy | |
| strategy: {} |
Contributor
|
Hey, thank you for the contribution. I just approved the workflows to run. The e2e tests will fail due to permission issues. This is expected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
- Coverage 69.25% 65.67% -3.58%
==========================================
Files 24 24
Lines 2657 2657
==========================================
- Hits 1840 1745 -95
- Misses 643 744 +101
+ Partials 174 168 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for customizing the deployment
strategy in the Helm chart.
The main enhancement allows users to specify deployment strategies,
such as
Replace, allowing an existing Pod to be destroyed before thenew one is allocated.
strategyin thedeployment.yamltemplate, which will use the values provided in.Values.strategy.Fixes #1189