feat: heroku sdk integration ps commands#3732
Merged
michaelmalave merged 9 commits intoMay 29, 2026
Merged
Conversation
fix: add missing warning to 'data:pg:migrate'
…3724) Both Claude Code and GitHub Copilot Code Review look for tool-specific instruction files (CLAUDE.md and .github/copilot-instructions.md respectively). Point both at the canonical AGENTS.md so we don't have to maintain duplicate guidelines per tool.
…#3721) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
fix: 'run:inside' args ordering
…g shared runUpgrade/prepareUpgrade/dryRunUpgrade helpers and refactor the corresponding upgrade commands to use them instead of repeating inline SDK method casting.
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
…targeted @ts-expect-error annotations and explicit function types to document current heroku-types gaps while keeping calls type-safe.
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
eablack
reviewed
May 28, 2026
Contributor
eablack
left a comment
eablack
left a comment
There was a problem hiding this comment.
It's good that we're integrated the SDK successfully here, but a big part of what we're trying to accomplish with it isn't just to replace the underlying API client (though that is an exciting part of it) -- we also want to abstract useful logic workflows from the CLI into the SDK so we can use them elsewhere. scale seems like a worthwhile candidate for that. Lemme know what you think.
…interactions in ps:index/ps:scale, and update lockfile and unit tests to match the simplified implementation and typing behavior
…mplify quota parameter handling, while tightening ps:scale type-safe shield size formatting to avoid unsafe fallback conversions
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Failure
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
michaelmalave
had a problem deploying
to
AcceptanceTests
GitHub Actions
Error
eablack
approved these changes
May 29, 2026
michaelmalave
merged commit 66cd833
into
feat/heroku-sdk-integration
4 of 17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refines the SDK migration work on top of
feat/heroku-sdk-integrationby simplifyingpscommand implementation and consolidating typing/call patterns in the touched command paths. Scope is limited topscommands, minor maintenance-command alignment, and related test/lockfile updates.ps:index,ps:restart, andps:scaleto use streamlined SDK interaction patternspsunit tests to match the revised SDK call flow and output expectationspackage-lock.jsonto reflect dependency state after the refactorType of Change
Verification
Additional Context
feat/heroku-sdk-integrationRelated Issue
W-22265197