Skip to content

fix: prevent spinner from interfering with 2FA prompt in heroku run and heroku console #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eablack merged 1 commit into from
Feb 27, 2026
Merged

fix: prevent spinner from interfering with 2FA prompt in heroku run and heroku console #3545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/run/dyno.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ export default class Dyno extends Duplex {
// Starts the dyno
async start() {
this._startedAt = Date.now()
if (this.opts.showStatus) {
ux.action.start(`Running ${color.code(this.opts.command)} on ${color.app(this.opts.app)}`)
}

await this._doStart()
}

Expand Down Expand Up @@ -178,6 +174,12 @@ export default class Dyno extends Duplex {
})
// @ts-ignore
this.dyno = dyno.body

// Show status after dyno is created (after any 2FA prompt)
if (this.opts.showStatus) {
ux.action.start(`Running ${color.code(this.opts.command)} on ${color.app(this.opts.app)}`)
}

if (this.opts.attach || this.opts.dyno) {
// @ts-ignore
if (this.dyno.name && this.opts.dyno === undefined) {
Expand Down
Loading