fix(auth): update code/token generation from CLI and redirect to successful page#518
fix(auth): update code/token generation from CLI and redirect to successful page#518eduardoRoth wants to merge 7 commits intomainfrom
Conversation
…to `cli-log-in` page
eduardoRoth
force-pushed
the
fix/eroth/auth-update
branch
from
c4afd3c to
db76111
Compare
jeremymwells
left a comment
jeremymwells
left a comment
There was a problem hiding this comment.
LGTM.
Is there no way to test this?
|
@jeremymwells , you can pull this branch and the branch of #350 from
You need to add to your |
|
@eduardoRoth - fair point. I meant automated tests. Also, macos, ubuntu, and windows node version tests should pass, right? |
|
@jeremymwells whoops, sorry, i thought you wanted to test it. |
| res.end(); | ||
| resolve(token); | ||
| }) | ||
| .catch((error) => reject(error)) |
There was a problem hiding this comment.
I think we need to refactor this function as its complexity is very high. Can we try to break it into smaller functions? Mixing async await and then catch syntax produces unexpected results. (for example the .catch is not catching rejections from an awaited promise), its better to avoid this pattern completely, given that we are also in another new promise.
4 participants
Changes required by https://github.com/neverendingsupport/eol-report-card/pull/350 to allow users to keep their authenticated session on the web app after a successful authentication from the CLI.
This PR changes the flow for the code and token generation. Before the local server was stopped after the
codefrom keycloak was received, sending atext/painresponse, and generating the tokens after that.The new flow generates the code, then the tokens and, after getting them, it redirects to a page on the
eol-report-cardweb app that handles the creation of the session cookie.