Skip to content

perf(tcp): optimize active socket search #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkroening merged 1 commit into from
May 28, 2026
Merged

perf(tcp): optimize active socket search #2435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/fd/socket/tcp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,19 +313,15 @@ impl ObjectInterface for Socket {
let connection_handle = future::poll_fn(|cx| {
let mut guard = NIC.lock();
let nic = guard.as_nic_mut().unwrap();
let mut socket_handle = None;

for handle in self.handle.iter() {
let s = nic.get_mut_socket::<tcp::Socket<'_>>(*handle);

if s.is_active() {
socket_handle = Some(*handle);
break;
}
}
let socket_handle = self
.handle
.extract_if(.., |handle| {
nic.get_mut_socket::<tcp::Socket<'_>>(*handle).is_active()
})
.next();

if let Some(handle) = socket_handle {
self.handle.remove(&handle);
Poll::Ready(Ok(handle))
} else if self.is_nonblocking {
Poll::Ready(Err(Errno::Again))
Expand Down
Loading