Skip to content

refactor(pic): make code more readable#2336

Merged
mkroening merged 3 commits intomainfrom
refactor-pic
Mar 18, 2026
Merged

refactor(pic): make code more readable#2336
mkroening merged 3 commits intomainfrom
refactor-pic

Conversation

@mkroening
Copy link
Copy Markdown
Member

Extracted from #2320.

@mkroening mkroening self-assigned this Mar 18, 2026
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 0eb6462 Previous: 3ac3315 Performance Ratio
startup_benchmark Build Time 89.11 s 89.27 s 1.00
startup_benchmark File Size 0.75 MB 0.75 MB 1.00
Startup Time - 1 core 0.92 s (±0.03 s) 0.94 s (±0.03 s) 0.98
Startup Time - 2 cores 0.95 s (±0.04 s) 0.95 s (±0.04 s) 1.00
Startup Time - 4 cores 0.96 s (±0.04 s) 0.94 s (±0.04 s) 1.03
multithreaded_benchmark Build Time 89.89 s 90.01 s 1.00
multithreaded_benchmark File Size 0.86 MB 0.86 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 87.93 % (±6.87 %) 87.64 % (±8.51 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 43.81 % (±2.81 %) 44.09 % (±3.51 %) 0.99
Multithreaded Pi Efficiency - 8 Threads 25.61 % (±1.88 %) 25.59 % (±2.01 %) 1.00
micro_benchmarks Build Time 91.55 s 101.16 s 0.90
micro_benchmarks File Size 0.86 MB 0.86 MB 1.00
Scheduling time - 1 thread 65.54 ticks (±4.60 ticks) 67.87 ticks (±3.85 ticks) 0.97
Scheduling time - 2 threads 35.78 ticks (±4.21 ticks) 36.50 ticks (±3.51 ticks) 0.98
Micro - Time for syscall (getpid) 2.93 ticks (±0.28 ticks) 3.01 ticks (±0.28 ticks) 0.98
Memcpy speed - (built_in) block size 4096 64814.56 MByte/s (±46474.21 MByte/s) 63042.69 MByte/s (±45031.72 MByte/s) 1.03
Memcpy speed - (built_in) block size 1048576 29358.08 MByte/s (±24325.04 MByte/s) 29485.06 MByte/s (±24652.84 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 28193.17 MByte/s (±23484.60 MByte/s) 24243.73 MByte/s (±20316.34 MByte/s) 1.16
Memset speed - (built_in) block size 4096 65802.19 MByte/s (±47132.51 MByte/s) 63340.46 MByte/s (±45234.84 MByte/s) 1.04
Memset speed - (built_in) block size 1048576 30148.92 MByte/s (±24761.77 MByte/s) 30262.35 MByte/s (±25094.12 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 28964.41 MByte/s (±23921.00 MByte/s) 25000.39 MByte/s (±20810.68 MByte/s) 1.16
Memcpy speed - (rust) block size 4096 58913.99 MByte/s (±43318.48 MByte/s) 57707.44 MByte/s (±42356.96 MByte/s) 1.02
Memcpy speed - (rust) block size 1048576 29312.62 MByte/s (±24300.55 MByte/s) 29531.70 MByte/s (±24724.94 MByte/s) 0.99
Memcpy speed - (rust) block size 16777216 28335.69 MByte/s (±23590.07 MByte/s) 23609.81 MByte/s (±19627.11 MByte/s) 1.20
Memset speed - (rust) block size 4096 59213.22 MByte/s (±43481.19 MByte/s) 58813.21 MByte/s (±43151.54 MByte/s) 1.01
Memset speed - (rust) block size 1048576 30104.66 MByte/s (±24757.05 MByte/s) 30349.84 MByte/s (±25196.60 MByte/s) 0.99
Memset speed - (rust) block size 16777216 29101.01 MByte/s (±24025.99 MByte/s) 24408.86 MByte/s (±20187.08 MByte/s) 1.19
alloc_benchmarks Build Time 91.15 s 91.28 s 1.00
alloc_benchmarks File Size 0.82 MB 0.82 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 16111.92 Ticks (±288.36 Ticks) 8755.83 Ticks (±1298.90 Ticks) 1.84
Allocations - Average Allocation time (no fail) 16111.92 Ticks (±288.36 Ticks) 8755.83 Ticks (±1298.90 Ticks) 1.84
Allocations - Average Deallocation time 1135.11 Ticks (±425.59 Ticks) 3030.46 Ticks (±622.25 Ticks) 0.37
mutex_benchmark Build Time 91.48 s 98.19 s 0.93
mutex_benchmark File Size 0.86 MB 0.86 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.80 ns (±0.72 ns) 12.98 ns (±0.76 ns) 0.99
Mutex Stress Test Average Time per Iteration - 2 Threads 19.30 ns (±7.31 ns) 18.68 ns (±9.78 ns) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 9f7322b Mar 18, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants