Skip to content

Refactor PartitionsSaxHandler to use boost::json#1670

Open
asopov-here wants to merge 8 commits intofeature_boost_jsonfrom
task/OCMAM-448
Open

Refactor PartitionsSaxHandler to use boost::json#1670
asopov-here wants to merge 8 commits intofeature_boost_jsonfrom
task/OCMAM-448

Conversation

@asopov-here
Copy link
Contributor

Relates-To: OCMAM-448

@asopov-here asopov-here force-pushed the task/OCMAM-448 branch 3 times, most recently from 15b17c6 to f501541 Compare February 26, 2026 17:52
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 88.63636% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature_boost_json@d6b6721). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rvice-read/src/repositories/PartitionsSaxHandler.h 70.83% 7 Missing ⚠️
...ice-read/src/repositories/PartitionsRepository.cpp 85.71% 0 Missing and 2 partials ⚠️
...aservice-read/src/repositories/AsyncJsonStream.cpp 94.74% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature_boost_json    #1670   +/-   ##
=====================================================
  Coverage                      ?   80.38%           
=====================================================
  Files                         ?      351           
  Lines                         ?    14069           
  Branches                      ?     1516           
=====================================================
  Hits                          ?    11308           
  Misses                        ?     2146           
  Partials                      ?      615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asopov-here asopov-here changed the base branch from master to feature_boost_json February 27, 2026 07:57
@asopov-here asopov-here force-pushed the task/OCMAM-448 branch 4 times, most recently from 5a1ab0f to 79db427 Compare February 27, 2026 10:56
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Previously it was based on rapidjson
The tests are adjusted accordingly.

Relates-To: OCMAM-448
Signed-off-by: Alexander Sopov <ext-alexander.sopov@here.com>
Copy link
Collaborator

@rustam-gamidov-here rustam-gamidov-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check not resolved/responded comment
#1670 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants