Fixed KeyMap issue with pandas 3.0.0: issue #1329#1330
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1329 where KeyMap._remap() fails on pandas 3.0.x by adjusting how the internal mapping Series is constructed, and it expands unit test coverage to include numeric-key remapping scenarios that were previously problematic.
Changes:
- Updated
KeyMap._remap()to construct the mappingpd.Serieswith explicitdataandindexfor pandas 3.0+ compatibility. - Added multiple new
KeyMap.remap()unit tests covering numeric keys, stringified numeric keys,n/avalues, and multi-key cascading cases.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
hed/tools/analysis/key_map.py |
Builds the mapping Series using explicit data/index to avoid pandas 3.0.x construction behavior. |
tests/tools/analysis/test_key_map.py |
Adds regression tests for numeric-key and multi-key remapping scenarios tied to issue #1329. |
Comment on lines
+262
to
+269
| df_result, missing = key_map.remap(test_df) | ||
|
|
||
| self.assertEqual(len(df_result), 6, "remap should preserve number of rows") | ||
| self.assertEqual(df_result.iloc[0]['result'], 'correct_left') | ||
| self.assertEqual(df_result.iloc[1]['result'], 'correct_right') | ||
| # Rows with missing key combinations should get 'n/a' | ||
| self.assertEqual(df_result.iloc[2]['result'], 'n/a') | ||
| self.assertEqual(df_result.iloc[3]['result'], 'n/a') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #1329