Add pydantic v1 compatibility shim for v2 environments#1
Open
mmanzur2 wants to merge 2 commits intobase-v1.15.0from
Open
Add pydantic v1 compatibility shim for v2 environments#1mmanzur2 wants to merge 2 commits intobase-v1.15.0from
mmanzur2 wants to merge 2 commits intobase-v1.15.0from
Conversation
Add a central shim at _pydantic.py that routes imports through pydantic.v1 when pydantic v2 is detected. Hardcode PYDANTIC_V1=True in _compat.py so this fork always uses v1 behavior. Update all files to use the shim instead of importing directly from pydantic. Also fix pre-existing pyright errors: add missing params to model_dump/model_dump_json overrides and cast test fixtures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use knockapi._pydantic imports in tests for Field and ValidationError - Check both v1 and v2 BaseModel in _response.py issubclass checks Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/knockapi/_pydantic.pythat imports frompydantic.v1when pydantic v2 is detected, falling back to directpydanticimports for native v1PYDANTIC_V1 = Truein_compat.pyso this fork always uses v1 behaviormodel_dump/model_dump_jsonoverrides andtest_bulk.pyTest plan
🤖 Generated with Claude Code