Fix color problems with HDMI-In at 90Hz+ modes#604
Open
RaceMiata wants to merge 1 commit intohd-zero:mainfrom
Open
Fix color problems with HDMI-In at 90Hz+ modes#604RaceMiata wants to merge 1 commit intohd-zero:mainfrom
RaceMiata wants to merge 1 commit intohd-zero:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: HDMI-In modes at 90Hz and up get wrong colors. It may start out looking normal but as time goes on even without any change on the screen the colors start shimmer and shift to the point they get very much off.
Having had some discussions and diagnostics on discord with "Alf Skaar", I started looking at the vtmg code and noticed with case HDMI_VTMG_720P100 it makes system call to change vdpo to 720p30 mode. I wonder why it's not set to 720p90 instead so I tried and it fixed the color problem on my BoxPro! I can set up Windows to the listed 1280x720p100Hz mode or my 1280x720p90Hz mode (with my custom timing) no color issues.
I'm not sure if the code change should apply to goggle 1 and 2 though since I haven't heard anybody having same problem with them. I don't have goggle 1 or 2 so should I make the code change for google 1 and 2 also and let people have those goggles to test?