Skip to content

fix(love): use addCollection/createTxCollectionCUD for MeetingMinutes creation #10527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spatialy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(love): use addCollection/createTxCollectionCUD for MeetingMinutes creation #10527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/love/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export class TMeeting extends TEvent implements Meeting {
room!: Ref<Room>
}

@Model(love.class.MeetingMinutes, core.class.Doc, DOMAIN_MEETING_MINUTES)
@Model(love.class.MeetingMinutes, core.class.AttachedDoc, DOMAIN_MEETING_MINUTES)
@UX(
love.string.MeetingMinutes,
love.icon.MeetingMinutes,
Expand Down
7 changes: 2 additions & 5 deletions plugins/love-resources/src/meetings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,10 @@ async function moveToMeetingRoom (room: Room): Promise<void> {

async function createMeetingDocument (room: Room): Promise<void> {
const client = getClient()
await client.createDoc(love.class.MeetingMinutes, core.space.Workspace, {
await client.addCollection(love.class.MeetingMinutes, core.space.Workspace, room._id, love.class.Room, 'meetings', {
description: null,
attachedTo: room._id,
status: MeetingStatus.Active,
title: await getNewMeetingTitle(room),
attachedToClass: love.class.Room,
collection: 'meetings'
title: await getNewMeetingTitle(room)
})
}

Expand Down
9 changes: 8 additions & 1 deletion server-plugins/love-resources/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ async function roomJoinHandler (info: ParticipantInfo, control: TriggerControl):
year: 'numeric'
})
.replace(',', ' at')
const tx = control.txFactory.createTxCreateDoc(
const innerTx = control.txFactory.createTxCreateDoc(
love.class.MeetingMinutes,
core.space.Workspace,
{
Expand All @@ -238,6 +238,13 @@ async function roomJoinHandler (info: ParticipantInfo, control: TriggerControl):
},
_id
)
const tx = control.txFactory.createTxCollectionCUD(
love.class.Room,
info.room,
core.space.Workspace,
'meetings',
innerTx
)
tx.space = core.space.Tx
res.push(tx)
res.push(
Expand Down
Loading