Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
========================================
Coverage 94.58% 94.59%
========================================
Files 393 394 +1
Lines 25083 25276 +193
========================================
+ Hits 23726 23910 +184
- Misses 1357 1366 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ihsandemir
reviewed
Mar 6, 2026
|
|
||
| def __init__(self, service_name, name, context): | ||
| super(PartitionSpecificProxy, self).__init__(service_name, name, context) | ||
| partition_key = context.serialization_service.to_data(string_partition_strategy(name)) |
Contributor
There was a problem hiding this comment.
why is it hard coded string_partition_strategy? In Java, this is configurable.
Contributor
Author
There was a problem hiding this comment.
Ported that directly from the asyncore client.
I don't think any client other than Java has that configurable.
| >>> print("list.size", await my_list.size()) | ||
|
|
||
| Warning: | ||
| Asyncio client list proxy is not thread-safe, do not access it from other threads. |
Contributor
There was a problem hiding this comment.
why? different from asyncoore?
Contributor
Author
There was a problem hiding this comment.
That's how the asyncio client is built. Mixing threading and asyncio is not good practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straightforward port of
Listto asyncio.