Stop parsing tags as a part of Version (x.y.z-tag) - #12188
Draft
Bodigrim wants to merge 1 commit into
Draft
Conversation
Bodigrim
force-pushed
the
no-version-tags
branch
3 times, most recently
from
July 31, 2026 19:09
81e9a58 to
1fa8762
Compare
Bodigrim
force-pushed
the
no-version-tags
branch
from
July 31, 2026 20:58
1fa8762 to
db242bc
Compare
Bodigrim
marked this pull request as draft
July 31, 2026 22:05
Bodigrim
force-pushed
the
no-version-tags
branch
from
July 31, 2026 22:18
db242bc to
9e48c3d
Compare
Resolves #890. Currently we allow tags to be a part of package version, as in `x.y.z-tag`. Once parsed, we emit a warning that a version contains a tag and throw the tag away, it's not stored or used for anything. For many years (since 2018, I think) this was meant to give potential users of tags a heads up that the feature will be eventually removed - and now it's time to remove it. Hackage refuses to upload packages with tags in versions, so there is no historical debt. Note that `Distribution.Types.Version` is to represent versions of Cabal packages, distinct from `Distribution.Types.PkgconfigVersion` (versions of external programs from pkg-config database) and `base:Data.Version` (version of GHC).
Bodigrim
force-pushed
the
no-version-tags
branch
from
July 31, 2026 22:23
9e48c3d to
fd36572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #890.
Currently we allow tags to be a part of package version, as in
x.y.z-tag. Once parsed, we emit a warning that a version contains a tag and throw the tag away, it's not stored or used for anything. For many years (since 2018, I think) this was meant to give potential users of tags a heads up that the feature will be eventually removed - and now it's time to remove it.Hackage refuses to upload packages with tags in versions, so there is no historical debt.
Template Α: This PR modifies behaviour or interface
significance: significantin the changelog file.