Skip to content

Run ghc-supported-extensions on CI#11970

Open
sol wants to merge 1 commit into
masterfrom
run-ghc-supported-extensions-extensions-on-ci
Open

Run ghc-supported-extensions on CI#11970
sol wants to merge 1 commit into
masterfrom
run-ghc-supported-extensions-extensions-on-ci

Conversation

@sol

@sol sol commented Jun 13, 2026

Copy link
Copy Markdown
Member

@sol sol force-pushed the run-ghc-supported-extensions-extensions-on-ci branch from 1dc4749 to e24314d Compare June 13, 2026 13:54
@sol sol marked this pull request as ready for review June 13, 2026 13:55
@ffaf1

ffaf1 commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Running cabal check make sense, if something pops up most likely the author changed a .cabal file.

But I wonder: does this?
Are we expecting a contributor to add extensions on top what they are doing (which is 99% unrelated to that)?

@sol

sol commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Adding a new GHC version to the build matrix is a contribution. And I think yes, if somebody adds a new GHC to the build matrix, then they should update the list of extensions.

For other kinds of contributions, this should never fail.

@sol sol force-pushed the run-ghc-supported-extensions-extensions-on-ci branch from e24314d to 70f7f96 Compare June 13, 2026 16:03
@sol sol force-pushed the run-ghc-supported-extensions-extensions-on-ci branch from 70f7f96 to dbde496 Compare June 13, 2026 16:05
@sol sol requested review from andreasabel and philderbeast June 13, 2026 16:33

@ffaf1 ffaf1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

@Bodigrim Bodigrim added the merge me Tell Mergify Bot to merge label Jun 14, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Jun 14, 2026
@Mikolaj

Mikolaj commented Jun 16, 2026

Copy link
Copy Markdown
Member

Thank you for that. This would be problematic in the past workflow, where we waited for an alpha GHC release before releasing a corresponding cabal release, because we could use the alpha GHC to run this test, but we would not want to add an alpha GHC to CI (and it would take too long anyway, with lots of random Windows CI errors popping up with new GHC releases back then). However, nowadays we start releasing cabal without waiting for an alpha GHC release, so this check is no longer particularly useful for a cabal release, but it's still useful as a sanity check later on, so running it, in particular, when we add a new GHC to CI is enough.

@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jun 16, 2026
@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 35 minutes 40 seconds in the queue, including 1 hour 24 minutes 20 seconds running CI.

Waiting for any of
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify Bot added a commit that referenced this pull request Jun 16, 2026
@mergify mergify Bot added dequeued and removed queued labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport 3.18 dequeued merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants