Run ghc-supported-extensions on CI#11970
Conversation
1dc4749 to
e24314d
Compare
|
Running But I wonder: does this? |
|
Adding a new GHC version to the build matrix is a contribution. And I think yes, if somebody adds a new GHC to the build matrix, then they should update the list of extensions. For other kinds of contributions, this should never fail. |
e24314d to
70f7f96
Compare
70f7f96 to
dbde496
Compare
|
Thank you for that. This would be problematic in the past workflow, where we waited for an alpha GHC release before releasing a corresponding cabal release, because we could use the alpha GHC to run this test, but we would not want to add an alpha GHC to CI (and it would take too long anyway, with lots of random Windows CI errors popping up with new GHC releases back then). However, nowadays we start releasing cabal without waiting for an alpha GHC release, so this check is no longer particularly useful for a cabal release, but it's still useful as a sanity check later on, so running it, in particular, when we add a new GHC to CI is enough. |
Merge Queue Status
This pull request spent 1 hour 35 minutes 40 seconds in the queue, including 1 hour 24 minutes 20 seconds running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks Failing checks: HintYou may have to fix your CI before adding the pull request to the queue again. |
This was part of the pre-flight checklist, which I would like to get rid of.
https://github.com/haskell/cabal/wiki/Making-a-release/_compare/b91547b5d7713283754058ea20152d9e915ba043...2c02bf94536d0669a7742882cb46a97b5eda422c