Skip to content

Running cabal doctest with ghc-9.12#11929

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:fix/cabal-doctest-ghc-9.12
Jun 8, 2026
Merged

Running cabal doctest with ghc-9.12#11929
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:fix/cabal-doctest-ghc-9.12

Conversation

@philderbeast

@philderbeast philderbeast commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes #11493. I found something that works by accident, pinning to doctest-0.25.0. This fix supercedes the one from #11793 and sticks with using cabal doctest for the doctests. I also log the version of cabal we use when running doctests and bumped to ghc-9.12.4, the ghc used for running quick-jobs.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@mergify

mergify Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #11793. Mergify cannot evaluate rules on this PR. Once #11793 is merged or closed, Mergify will resume processing this PR. ⚠️

@philderbeast

Copy link
Copy Markdown
Collaborator Author

@mergify refresh

@mergify

mergify Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

Comment thread Makefile
Comment thread .github/workflows/quick-jobs.yml Outdated
@philderbeast philderbeast force-pushed the fix/cabal-doctest-ghc-9.12 branch from 93b5b00 to 7efa94d Compare June 4, 2026 09:35
@mouse07410

Copy link
Copy Markdown
Collaborator

I don't think is a good idea to move back from 9.12.4 to 9.12.2, for obvious reasons.

@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Jun 5, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Jun 5, 2026
@philderbeast philderbeast force-pushed the fix/cabal-doctest-ghc-9.12 branch 3 times, most recently from 847ee6d to 5d0fdf8 Compare June 5, 2026 10:18
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Jun 7, 2026
@mergify

mergify Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 hour 33 minutes 44 seconds in the queue, including 1 hour 22 minutes 4 seconds running CI.

Waiting for any of
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify Bot added a commit that referenced this pull request Jun 7, 2026
@mergify mergify Bot added dequeued and removed queued labels Jun 7, 2026
- Log the cabal version we're running doctests with
- Bump quick-jobs to use ghc-9.12.4
- Don't go as far as 9.12.4, use 9.12.2

Co-Authored-By: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
@philderbeast philderbeast force-pushed the fix/cabal-doctest-ghc-9.12 branch from 5d0fdf8 to a47eadb Compare June 8, 2026 01:02
@mergify mergify Bot removed the dequeued label Jun 8, 2026
@philderbeast

Copy link
Copy Markdown
Collaborator Author

@mergify queue

@mergify

mergify Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • any of [🛡 GitHub branch protection]:
        • check-success = Doctest Cabal
        • check-neutral = Doctest Cabal
        • check-skipped = Doctest Cabal
      • any of [🛡 GitHub branch protection]:
        • check-success = Meta checks
        • check-neutral = Meta checks
        • check-skipped = Meta checks
      • any of [🛡 GitHub branch protection]:
        • check-success = docs/readthedocs.org:cabal
        • check-neutral = docs/readthedocs.org:cabal
        • check-skipped = docs/readthedocs.org:cabal
      • any of [🛡 GitHub branch protection]:
        • check-success = Validate post job
        • check-neutral = Validate post job
        • check-skipped = Validate post job
      • any of [🛡 GitHub branch protection]:
        • check-success = fourmolu
        • check-neutral = fourmolu
        • check-skipped = fourmolu
      • any of [🛡 GitHub branch protection]:
        • check-success = hlint
        • check-neutral = hlint
        • check-skipped = hlint
      • any of [🛡 GitHub branch protection]:
        • check-success = Bootstrap post job
        • check-neutral = Bootstrap post job
        • check-skipped = Bootstrap post job
      • any of [🛡 GitHub branch protection]:
        • check-success = whitespace
        • check-neutral = whitespace
        • check-skipped = whitespace
      • any of [🛡 GitHub branch protection]:
        • check-success = Check sdist post job
        • check-neutral = Check sdist post job
        • check-skipped = Check sdist post job
      • any of [🛡 GitHub branch protection]:
        • check-success = Changelogs
        • check-neutral = Changelogs
        • check-skipped = Changelogs
    • all of [📌 queue conditions of queue rule squash-merge]:
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • any of [🛡 GitHub branch protection]:
        • check-success = Doctest Cabal
        • check-neutral = Doctest Cabal
        • check-skipped = Doctest Cabal
      • any of [🛡 GitHub branch protection]:
        • check-success = Meta checks
        • check-neutral = Meta checks
        • check-skipped = Meta checks
      • any of [🛡 GitHub branch protection]:
        • check-success = docs/readthedocs.org:cabal
        • check-neutral = docs/readthedocs.org:cabal
        • check-skipped = docs/readthedocs.org:cabal
      • any of [🛡 GitHub branch protection]:
        • check-success = Validate post job
        • check-neutral = Validate post job
        • check-skipped = Validate post job
      • any of [🛡 GitHub branch protection]:
        • check-success = fourmolu
        • check-neutral = fourmolu
        • check-skipped = fourmolu
      • any of [🛡 GitHub branch protection]:
        • check-success = hlint
        • check-neutral = hlint
        • check-skipped = hlint
      • any of [🛡 GitHub branch protection]:
        • check-success = Bootstrap post job
        • check-neutral = Bootstrap post job
        • check-skipped = Bootstrap post job
      • any of [🛡 GitHub branch protection]:
        • check-success = whitespace
        • check-neutral = whitespace
        • check-skipped = whitespace
      • any of [🛡 GitHub branch protection]:
        • check-success = Check sdist post job
        • check-neutral = Check sdist post job
        • check-skipped = Check sdist post job
      • any of [🛡 GitHub branch protection]:
        • check-success = Changelogs
        • check-neutral = Changelogs
        • check-skipped = Changelogs

@mergify mergify Bot added the queued label Jun 8, 2026
@mergify

mergify Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-06-08 02:33 UTC · Rule: default
  • Checks skipped · PR is already up-to-date
  • Merged2026-06-08 02:44 UTC · at a47eadb3d70ca1ba495a6e4b2aeeec1a2e717eb1 · merge

This pull request spent 11 minutes 15 seconds in the queue, including 3 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify mergify Bot merged commit 4960764 into haskell:master Jun 8, 2026
68 checks passed
@mergify mergify Bot removed the queued label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doctests with ghc-9.12.2 can't parse

5 participants