Add tests for active-repositories feature by erikd · Pull Request #11684 · haskell/cabal

erikd · 2026-04-01T02:03:58Z

This PR only contains tests, which were generated by Claude code, and then manually reviewed. Unfortunately I have not worked much on Cabal so my manual review may not be up-to-scratch.

This PR was submitted in preparation for taking over the work in #8997 and getting it merged. One of the things mentioned in that PR was that need for tests for the active-repositories feature.

Include the following checklist in your PR:

Patches conform to the coding conventions.
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

erikd · 2026-04-01T04:39:52Z

I asked Claude to give me an idea of the test coverage. Its response:

Where:

Layer 1 — pure logic (ActiveRepos.hs)
Layer 2 — project config parsing (pre-existing tests only, nothing new in this PR)
Layer 3 — index combining (IndexUtils.hs) (all 14 combining tests are in this PR)
Layer 4 — freeze file (filterSkippedActiveRepos unit tests in this PR)
Layer 5 — solver/planning wiring

These tests were generated by Claude code, but manually reviewed.

andreabedini

I left a couple of comments but otherwise LGTM.

Not a deal breaker but any chance you can add a simple test for this edge case behaviour?

-- Note: currently if 'ActiveRepoRest' is provided more than once,
-- rest-repositories will be multiple times in the output.

andreabedini · 2026-04-02T08:38:19Z

cabal-install/tests/UnitTests/Distribution/Client/IndexUtils.hs

+          @?= sort [foo1, bar1]
+    , testCase "Merge+Override: override repo replaces all versions of overlapping package" $
+        -- repoFoo12 has foo-1.0 and foo-1.1; repoFoo2 has only foo-2.0.
+        -- Override means repoFoo2 wins the entire 'foo' bucket.


This comments seems wrong. Below we have

repoFoo12 = PackageIndex.fromList [foo1, foo2]

So repoFoo12 has foo-1.0 and foo-2.0. I am not sure what was intended.

andreabedini · 2026-04-02T08:40:03Z

cabal-install/tests/UnitTests/Distribution/Client/IndexUtils.hs

+pkgs
+  :: [(PackageIndex.PackageIndex PackageIdentifier, CombineStrategy)]
+  -> [PackageIdentifier]
+pkgs = sort . PackageIndex.allPackages . foldl combineIndex mempty


Suggested change

pkgs = sort . PackageIndex.allPackages . foldl combineIndex mempty

pkgs = sort . PackageIndex.allPackages . foldl' combineIndex mempty

This is extra picky but since we say Mirrors the addIndex / foldl' in getSourcePackagesAtIndexState we might as well reproduce the same behaviour.

BTH I am not sure testing a reimplementation is a good idea, it will go out of sync with the actual code and lose all its value. Can we perhaps export from IndexUtils the functions we want to test here?

mergify · 2026-04-02T08:47:59Z

Merge Queue Status

✅ Entered queue — 2026-04-02 07:42 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11691
🚫 Left the queue — 2026-04-02 08:48 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 1 hour 5 minutes 23 seconds in the queue, including 3 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T08:48:36Z

Merge Queue Status

✅ Entered queue — 2026-04-02 08:48 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11692
🚫 Left the queue — 2026-04-02 08:59 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 11 minutes 12 seconds in the queue, including 44 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

andreabedini · 2026-04-02T08:49:37Z

A changelog file is missing, here is a suggestion:

---
synopsis: Add unit tests for active-repositories feature
packages: [cabal-install]
prs: 11684
---

Add unit tests for the `active-repositories` cabal configuration field:

- `organizeByRepos`: ordering and strategy assignment with `:rest`, named repos, and error cases
- `filterSkippedActiveRepos`: filtering of skipped entries in the absence of `:rest`
- `CombineStrategy` index-combining logic (Skip/Merge/Override)
- Parse/pretty roundtrip for `ActiveRepos` (QuickCheck)

mergify · 2026-04-02T09:00:57Z

Merge Queue Status

✅ Entered queue — 2026-04-02 09:00 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11693
🚫 Left the queue — 2026-04-02 09:11 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 10 minutes 45 seconds in the queue, including 4 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T09:12:05Z

Merge Queue Status

✅ Entered queue — 2026-04-02 09:11 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11694
🚫 Left the queue — 2026-04-02 09:23 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 11 minutes 20 seconds in the queue, including 26 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T09:24:02Z

Merge Queue Status

✅ Entered queue — 2026-04-02 09:23 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11695
🚫 Left the queue — 2026-04-02 09:34 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 10 minutes 48 seconds in the queue, including 32 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T23:04:42Z

Merge Queue Status

✅ Entered queue — 2026-04-02 16:59 UTC · Rule: default
✅ Checks started · on draft merge queue: embarking master (4b56b0d) and #11684 together #11700
🚫 Left the queue — 2026-04-02 23:04 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 6 hours 5 minutes 24 seconds in the queue, including 3 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-03T09:09:48Z

Merge Queue Status

✅ Entered queue — 2026-04-03 07:10 UTC · Rule: default
✅ Checks started · on draft merge queue: embarking master (575acc9) and #11684 together #11702
🚫 Left the queue — 2026-04-03 09:10 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 1 hour 59 minutes 18 seconds in the queue, including 12 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

geekosaur · 2026-04-03T17:41:56Z

Do we know why this is being repeatedly queued without a merge label? The Mergify summary doesn't show it matching any of the merge rules (correct), and even if it were the presence of unresolved comments and lack of reviews should be blocking it from entering the queue at all.

geekosaur · 2026-04-03T17:42:17Z

@Mergifyio refresh

mergify · 2026-04-03T17:42:25Z

✅ Pull request refreshed

erikd · 2026-04-04T04:24:34Z

I will rebase against master and address @andreabedini 's comments on Tuesday, April 7th

mergify · 2026-04-05T05:05:38Z

Merge Queue Status

✅ Entered queue — 2026-04-05 03:18 UTC · Rule: default
✅ Checks started · on draft merge queue: embarking master (71b3c85) and #11684 together #11707
🚫 Left the queue — 2026-04-05 05:05 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 1 hour 46 minutes 54 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

erikd force-pushed the master branch from 5162f1f to 6898e42 Compare April 1, 2026 02:08

erikd mentioned this pull request Apr 1, 2026

Don't override a package if all versions are deprecated #8997

Open

8 tasks

erikd force-pushed the master branch from 6898e42 to 8a79072 Compare April 1, 2026 20:35

Add tests for active-repositories feature

335c948

These tests were generated by Claude code, but manually reviewed.

erikd force-pushed the master branch from 8a79072 to 335c948 Compare April 2, 2026 01:08

andreabedini approved these changes Apr 2, 2026

View reviewed changes

mergify bot added the queued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

910f380

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11691

Closed

128 tasks

mergify bot added the dequeued label Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

27425ed

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11692

Closed

128 tasks

mergify bot added dequeued queued and removed queued labels Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

706dea6

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11693

Closed

128 tasks

mergify bot added dequeued queued and removed queued labels Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

3d1bb8f

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11694

Closed

116 tasks

mergify bot added the dequeued label Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

11d8161

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11695

Closed

112 tasks

mergify bot added dequeued queued and removed queued labels Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

d56eac0

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (4b56b0d) and #11684 together #11700

Closed

128 tasks

mergify bot added queued and removed queued labels Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 3, 2026

Merge of #11684

028d271

mergify bot mentioned this pull request Apr 3, 2026

merge queue: embarking master (575acc9) and #11684 together #11702

Closed

128 tasks

mergify bot removed the queued label Apr 3, 2026

mergify bot added the queued label Apr 5, 2026

mergify bot added a commit that referenced this pull request Apr 5, 2026

Merge of #11684

4db84ec

mergify bot mentioned this pull request Apr 5, 2026

merge queue: embarking master (71b3c85) and #11684 together #11707

Closed

128 tasks

mergify bot removed the queued label Apr 5, 2026

	pkgs = sort . PackageIndex.allPackages . foldl combineIndex mempty
	pkgs = sort . PackageIndex.allPackages . foldl' combineIndex mempty

Conversation

erikd commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikd commented Apr 1, 2026

Uh oh!

andreabedini left a comment

Choose a reason for hiding this comment

Uh oh!

andreabedini Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

andreabedini Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

andreabedini commented Apr 2, 2026

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

geekosaur commented Apr 3, 2026

Uh oh!

geekosaur commented Apr 3, 2026

Uh oh!

mergify bot commented Apr 3, 2026

✅ Pull request refreshed

Uh oh!

erikd commented Apr 4, 2026

Uh oh!

mergify bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

erikd commented Apr 1, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 3, 2026 •

edited

Loading

mergify bot commented Apr 5, 2026 •

edited

Loading