Add MonadCatch and MonadMask instances to RouteResultT and DelayedIO#1830
Open
Add MonadCatch and MonadMask instances to RouteResultT and DelayedIO#1830
Conversation
tchoutri
force-pushed
the
1829-add-monadmask-monadcatch-to-delayed-io
branch
from
795bf9f to
1b88d8f
Compare
Contributor
Author
ysangkok
approved these changes
Aug 12, 2025
Contributor
ysangkok
left a comment
ysangkok
left a comment
There was a problem hiding this comment.
I think it would be good to have a test for this, since it is tricky. But it looks fine as far as I can glean.
Contributor
Author
|
@ysangkok I'm open to suggestions for the test, my imagination is failing me. |
tchoutri
force-pushed
the
1829-add-monadmask-monadcatch-to-delayed-io
branch
from
598b6aa to
e07e955
Compare
Contributor
|
The reason I asked for the tests is because I don't have much experience with exception handling and masking in Haskell, so I can't really imagine what the code that could be broken by this would look like. The test would help explain that to me. But I wouldn't oppose to just optimistically merging this if you are reasonably confident that it is an improvement. |
tchoutri
force-pushed
the
1829-add-monadmask-monadcatch-to-delayed-io
branch
from
e07e955 to
f18ff26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1829