feat(supertasks): add "skip completed pretasks" option to apply-hashlist form#688
Open
linuxkd wants to merge 1 commit into
Open
feat(supertasks): add "skip completed pretasks" option to apply-hashlist form#688linuxkd wants to merge 1 commit into
linuxkd wants to merge 1 commit into
Conversation
…ist form Adds a skipCompleted checkbox to the apply-supertask form that passes the flag to the createSupertask helper and surfaces meta.skippedPretasks from the response (info toast for skipped pretasks, plus the all-skipped / taskWrapperId=null case). Defaults off, so existing behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the client-side control for the server-side supertask dedup feature (server PR hashtopolis/server#2177, feature request hashtopolis/server#2167).
A "Skip pretasks already completed" checkbox is added to the apply-supertask ("Use Supertask") form. When checked, it sends
skipCompleted: trueto thecreateSupertaskhelper and surfaces the server'smeta.skippedPretasksresponse — an info toast listing the skipped pretasks, plus the all-skipped (taskWrapperId == null, no wrapper created) case. Defaults off, so existing behavior is unchanged.Depends on
skipCompletedflag and themeta.skippedPretasksresponse. This UI is a no-op against a server without that change (the flag is simply ignored).Changes
applyhashlist.component.ts— adds askipCompletedFormControl (buildForm()+initForm()), sends it in thecreateSupertaskbody, types the callResponseWrapper<CreateSupertaskMeta>, surfacesmeta.skippedPretasksand the all-skipped case viaAlertService, and uses the{ next, error, complete }subscribe form (resetsisCreatingLoadingon error/complete).applyhashlist.component.html— the checkbox + explanatory tooltip.Testing
ng serve.Refs hashtopolis/server#2167