FE-684: Add checkbox to DS#8912
Conversation
PR SummaryMedium Risk Overview Ladle stories are reworked under Components/Checkbox to showcase the new variants. Petrinaut is updated to the new API for the “default starting place” control. Reviewed by Cursor Bugbot for commit 44264a4. Bugbot is set up for automated code reviews on this repo. Configure here. |
b245b9a to
030e760
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 030e760. Configure here.
030e760 to
5996551
Compare
kube
left a comment
There was a problem hiding this comment.
LGTM.
Only checked in Petrinaut though.
Don't know how this indeterminate issue Cursor bot was talking about actually is. :)
In my experience indeterminate is never really used so it's kind of moot - but with this api you just need to remember to manually set indeterminate false if the user makes a selection. I've gone with this api, since it matches the w3c api better where you can have indeterminate + checked or unchecked |

🌟 What is the purpose of this PR?
Updates the checkbox component in the DS with a new implementation
Also removed a few unused dependencies in ds-components
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: