FE-427: Handle inheritance in type graph viz, fix table empty state#8911
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
PR SummaryLow Risk Overview The type graph visualizer walks entity type User profile edit modal: cover image add/change/remove controls are commented out (cover not shown on profile yet); hidden upload handlers remain. Type editor inherited link rows use a single title tooltip for the inheritance source and drop redundant read-only tooltips on destination and cardinality cells to avoid overlapping popovers. Reviewed by Cursor Bugbot for commit 625a274. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
This PR applies a set of frontend UX fixes across the type editor and type/entity tables, focused on improving type graph visualization fidelity (inheritance + icons) and restoring meaningful empty states.
Changes:
- Extend the type graph visualizer to include inherited links and inherited icons when building graph nodes/edges.
- Ensure table/grid components render a visible empty state (minimum 1 row) so “no results” messaging appears.
- Temporarily disable cover image editing controls in the user profile modal header and adjust tooltip behavior in the type editor.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/@hashintel/type-editor/src/entity-type-editor/link-list-card/inherited-link-row.tsx | Refactors inherited link row tooltip behavior and cell layout. |
| apps/hash-frontend/src/pages/shared/types-table.tsx | Ensures the table container height accounts for at least one displayed row (supports empty state). |
| apps/hash-frontend/src/pages/shared/type-graph-visualizer.tsx | Adds inheritance-aware link/icon aggregation when building graph nodes/edges. |
| apps/hash-frontend/src/pages/@/[shortname].page/edit-user-profile-info-modal/user-profile-info-modal-header.tsx | Comments out cover image editing UI (keeps avatar editing). |
| apps/hash-frontend/src/components/grid/grid.tsx | Adjusts empty-state text and ensures the grid renders at least one row to display it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🌟 What is the purpose of this PR?
A few small fixes:
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🐾 Next steps
Later follow-ups: