Skip to content

FE-427: Handle inheritance in type graph viz, fix table empty state#8911

Merged
CiaranMn merged 5 commits into
mainfrom
cm/table-and-type-graph-viz-fixes
Jun 29, 2026
Merged

FE-427: Handle inheritance in type graph viz, fix table empty state#8911
CiaranMn merged 5 commits into
mainfrom
cm/table-and-type-graph-viz-fixes

Conversation

@CiaranMn

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

A few small fixes:

  1. The type graph viz wasn't handling inheritance (inherited links not showing), nor displaying icons on nodes.
  2. The entities and type tables weren't showing the 'No results shown' text.
  3. Commented out the user cover image editing UI as the cover image isn't actually shown
  4. Fixed some tooltips in the type editor that could clash with each other.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

🐾 Next steps

Later follow-ups:

  • H-4638: Better profile empty state
  • H-931: Display cover image in user profile, restore editing UI

Copilot AI review requested due to automatic review settings June 29, 2026 14:35
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jun 29, 2026 3:06pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jun 29, 2026 3:06pm
petrinaut Skipped Skipped Jun 29, 2026 3:06pm

@cursor

cursor Bot commented Jun 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Frontend-only UX and visualization logic; no auth, data persistence, or API contract changes.

Overview
Fixes empty filtered tables in the shared Grid by treating zero rows as an empty state (not real data): getCellContent and rows now require sortedAndFilteredRows.length > 0, and the idle message is "No results with the applied filters." The types table uses displayedRowCount so height still reserves one row for that message.

The type graph visualizer walks entity type allOf ancestors, merges inherited links (deduped by link base URL), resolves link schemas from full entityTypes context, and sets node icons from the nearest ancestor that defines one.

User profile edit modal: cover image add/change/remove controls are commented out (cover not shown on profile yet); hidden upload handlers remain.

Type editor inherited link rows use a single title tooltip for the inheritance source and drop redundant read-only tooltips on destination and cardinality cells to avoid overlapping popovers.

Reviewed by Cursor Bugbot for commit 625a274. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/apps labels Jun 29, 2026
@vercel vercel Bot temporarily deployed to Preview – petrinaut June 29, 2026 14:39 Inactive

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a set of frontend UX fixes across the type editor and type/entity tables, focused on improving type graph visualization fidelity (inheritance + icons) and restoring meaningful empty states.

Changes:

  • Extend the type graph visualizer to include inherited links and inherited icons when building graph nodes/edges.
  • Ensure table/grid components render a visible empty state (minimum 1 row) so “no results” messaging appears.
  • Temporarily disable cover image editing controls in the user profile modal header and adjust tooltip behavior in the type editor.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
libs/@hashintel/type-editor/src/entity-type-editor/link-list-card/inherited-link-row.tsx Refactors inherited link row tooltip behavior and cell layout.
apps/hash-frontend/src/pages/shared/types-table.tsx Ensures the table container height accounts for at least one displayed row (supports empty state).
apps/hash-frontend/src/pages/shared/type-graph-visualizer.tsx Adds inheritance-aware link/icon aggregation when building graph nodes/edges.
apps/hash-frontend/src/pages/@/[shortname].page/edit-user-profile-info-modal/user-profile-info-modal-header.tsx Comments out cover image editing UI (keeps avatar editing).
apps/hash-frontend/src/components/grid/grid.tsx Adjusts empty-state text and ensures the grid renders at least one row to display it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/hash-frontend/src/components/grid/grid.tsx
Copilot AI review requested due to automatic review settings June 29, 2026 14:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread apps/hash-frontend/src/components/grid/grid.tsx
@CiaranMn CiaranMn added this pull request to the merge queue Jun 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@CiaranMn CiaranMn added this pull request to the merge queue Jun 29, 2026
Merged via the queue into main with commit 1833cbf Jun 29, 2026
45 checks passed
@CiaranMn CiaranMn deleted the cm/table-and-type-graph-viz-fixes branch June 29, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

3 participants