FE-674: Suppress no-op Undo on hard apply + V3.0 polish

[kostandinang]

What

Six small polish commits over the V3.0 stack from a code-review pass.

Stacked on #117.

Changes

1. Doc sync: SIDE_CHAT.md §5.3 now agrees with §9 that V3.0 has one Resolve action.
2. Extract <PendingReviewSection> out of patch-list-overlay.tsx — overlay becomes pure layout. Focused tests follow.
3. Shared makeNeed fixture across overlay + section tests.
4. Network-call assertions on Resolve: one POST, one invalidation, no double-fire.
5. New test fixture covering 5+ downstream items + all relation kinds.
6. Suppress Undo for hard-only batches — the misleading no-op Undo click is gone. Saved-toast still fires after hard apply.

Test plan

• CI green; only user-visible change is Undo suppression on hard-only batches

[kostandinang]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• FE-674: Agent classifier UI on pending review rows #124
• FE-674: Side-chat polish + DiffPopover + saved-toast move #121
• FE-674: Inline source diff + edit-target on pending review rows #120
• FE-674: Plan V3.1 verification strategy + node-edit cards #119
• FE-674: Suppress no-op Undo on hard apply + V3.0 polish #118 👈 (View in Graphite)
• FE-674: Resolve pending review rows #117
• FE-674: Show pending review rows in the patch overlay #116
• FE-674: Open downstream-review rows on hard-impact edit #115
• FE-657: Direct in-place editing on the structured-list view #109
• FE-665: Show per-patch diffs in the staged-changes overlay #108
• FE-665: Show word-level diff on staged edits in side-chat #107
• FE-673: Side-chat Edit mode — edit, link, and drill-down patches #105
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Changes patch-list overlay composition and undo eligibility logic, which can affect core apply/undo UX and post-apply feedback. Risk is mitigated by expanded unit/integration tests around resolve behavior, toast visibility, and hard-edit cascade fixtures.

Overview
Refactors the patch-list overlay by extracting the reconciliation queue UI into a dedicated PendingReviewSection, and adds focused component tests that assert resolve calls are single-fire (including rapid double-click) and trigger a single query invalidation.

Polishes hard-impact apply behavior by tagging hard edit applies as noUndo, updating the patch-list reducer to hide Undo for batches with only noUndo entries, and adjusting the saved-toast effect to still show “Change saved” for hard applies while avoiding toast-clears except on a real canUndo: true → false transition.

Updates design docs (SIDE_CHAT.md) to clarify V3.0 ships a single per-row Resolve action (no target mutation), with richer multi-action/agent grouping deferred to V3.1, and strengthens server cascade coverage with a dense fixture ensuring one reconciliation_need opens per edge across all typed relations.

^{Reviewed by Cursor Bugbot for commit d2a3611. Bugbot is set up for automated code reviews on this repo. Configure here.}

[augmentcode]

🤖 Augment PR Summary

Summary: This PR finishes the V3.0 polish pass by extracting the cascade “Pending review” UI, tightening resolve/fixture tests, and hiding Undo for hard-only applies where undo is a no-op.

Changes:

• Updated docs/design/SIDE_CHAT.md to match V3.0 behavior: one per-row Resolve action and no target mutation.
• Extracted <PendingReviewSection /> from patch-list-overlay.tsx and added focused component tests for listing + resolve behavior (including double-click oracle assertions).
• Introduced a shared makeNeed test fixture for reconciliation-need records to keep row-shape setup consistent across tests.
• Added noUndo: true metadata for hard-impact edit applies and updated the patch-list reducer so canUndo excludes batches where every entry is noUndo.
• Adjusted the saved-toast effect so “Change saved” still appears for hard applies, while the inline Undo affordance remains conditional on canUndo.
• Added a dense server route test covering all five relation types on a 5+ downstream graph to assert the relation→kind cascade matrix.

Technical Notes: The UI now composes three independent sticky regions (staged changes, pending review, saved toast), and the “Undo” surface is suppressed specifically for hard-only batches where undo cannot reverse the source mutation.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f74f37c. Configure here.}