Add GenerateConfig testing mode to ImportState testing#638
Merged
Conversation
ansgarm
approved these changes
Mar 31, 2026
Member
ansgarm
left a comment
ansgarm
left a comment
There was a problem hiding this comment.
Looks good to me! Only one small question but that can be followed-up / your choice whether to address :)
| }) | ||
| if err != nil { | ||
| t.Fatalf("removing resource %s from copied state: %s", resourceName, err) | ||
| if !step.GenerateConfig { |
Member
There was a problem hiding this comment.
can we add a command why we don't delete the resource in this case? Is it deleted later through some cleanup or something instead?
Comment on lines
+534
to
+535
| // GenerateResourceConfig RPC is unimplemented, returning a null generated | ||
| // config to Terraform Core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
GenerateConfigtesting mode to import mode testing. This mode runs an import plan with-generate-config-outflag and throws an error if there is a diff produced in the plan when compared to the state in the previous step.Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
N/A