Single Workspace Skip - DefaultWorkspaceOnly#633
Conversation
…to av/add-single-workspace-skip # Conflicts: # helper/resource/statestore/statestore_test.go # helper/resource/testing.go
…ed test for default workspace logic and validation
…to av/add-single-workspace-skip
Resolve merge conflict in go.mod file and update dependencies.
austinvalle
left a comment
austinvalle
left a comment
There was a problem hiding this comment.
Looks like there is a small format change to the changelog needed, but everything else LGTM 🚀
| body: | ||
| helper/resource: Added `DefaultWorkspaceOnly` to enable testing state store implementations that don't support multiple workspaces. This is achieved by only running Terraform commands with the `default` workspace. |
There was a problem hiding this comment.
It's weird changie didn't raise an error here, as this looks like an invalid changelog 🤔 , it looks like the body would be empty because of the newline before helper/resource:
There was a problem hiding this comment.
Yeah for some reason if I do not put a new line it gets angry because it thinks that section needs a new header so maybe if I just format it differently?
There was a problem hiding this comment.
Yeah probably because of the : character, wrapping the entire thing in single quotes will treat it as a string literal in YAML, most of our changelogs have something similar:
There was a problem hiding this comment.
I tried that once before but then changie fails for some reason?
There was a problem hiding this comment.
Very interesting 🤔, it's likely an encoding problem 👀
Co-authored-by: Austin Valle <austinvalle@gmail.com>
3 participants
Related Issue
Fixes #
Description
This PR adds a DefaultWorkspaceOnly boolean to TestStep that makes it so tests are limited to the provider's default workspace, a special case that applies to testing StateStores
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No