Change base image used in acceptance tests

[anurag5sh]

Description

Replace test AMIs with HC-base images and fix nil pointer issues

Changes:

• Replaced several test AMIs with HashiCorp-compliant base images (hc-base-ubuntu-2204)
• Fixed nil pointer dereferences in checkSnapshotsDeleted() and related AWS API helper functions
• Added proper error handling for AWS SDK v2 calls (DescribeSnapshots, DescribeImages, DescribeImageAttribute)
• Updated checkSnapshotsDeleted() to handle AWS SDK v2 behavior where deleted snapshots return InvalidSnapshot.NotFound error

Future Work

Replace all remaining acceptance tests with HashiCorp-compliant base images for consistent test behavior across all builders.

[Copilot]

Pull request overview

Updates Amazon EBS acceptance tests to use newer base images and hardens AWS SDK v2 interactions to avoid nil dereferences and improve error handling.

Changes:

• Swaps several hard-coded source_ami values to HashiCorp base Ubuntu 22.04 images for more consistent acceptance test behavior.
• Adds error handling for testEC2Conn failures and nil/empty responses from DescribeImages.
• Updates snapshot deletion verification to account for AWS SDK v2’s InvalidSnapshot.NotFound behavior.

Comments suppressed due to low confidence (1)

builder/ebs/builder_acc_test.go:2231

• The provisioning command pipes credentials into chpasswd but also passes ubuntu as a positional argument (chpasswd [file]), which will make chpasswd try to read from a file named ubuntu and likely ignore stdin / fail. This will prevent the user account password from being set. Drop the extra argument so the password comes from stdin (or explicitly target the intended user).

				"sudo sed -i 's/^#PasswordAuthentication yes/PasswordAuthentication yes/' /etc/ssh/sshd_config",
				"sudo useradd -m -s /bin/bash user",
				"echo 'Setting up password for user'",
				"echo 'user:password' | sudo chpasswd ubuntu",
				"sudo usermod -aG sudo user",

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.