Skip to content

migrate to aws-sdk-go-v2#23109

Merged
Manishakumari-hc merged 17 commits intomainfrom
manisha/upgrade_aws
Feb 17, 2026
Merged

migrate to aws-sdk-go-v2#23109
Manishakumari-hc merged 17 commits intomainfrom
manisha/upgrade_aws

Conversation

@Manishakumari-hc
Copy link
Copy Markdown
Collaborator

@Manishakumari-hc Manishakumari-hc commented Dec 9, 2025 •
edited
Loading

  • migrated aws-sdk-go to aws-sdk-go-v2 .
  • made sure there are no more direct dependencies of aws-sdk-go(v1) available in the repo

Attached the UNIT_TEST run and MANUAL Developer Testing with CONSUL ACL Enabled test results :
The manual testing was done using my AWS creds
UNIT_TEST_RESULT.md
Manual_Test_Results.md
serviceMesh_test.md
AWS_LAMBDA_MANUAL_TEST_RESULTS.md

Workflow of AWS functions trigerred during testing process:
FlowChart of Workflow to trigger AWS related code functionalities.docx

@Manishakumari-hc
migrate to aws-sdk-go-v2
76d302a 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc Manishakumari-hc self-assigned this Dec 9, 2025
@github-actions github-actions Bot added theme/cli Flags and documentation for the CLI interface theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies pr/dependencies PR specifically updates dependencies of project labels Dec 9, 2025
@Manishakumari-hc
aws-sdk v2
8cec9cc 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc Manishakumari-hc added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Jan 9, 2026
@Manishakumari-hc Manishakumari-hc marked this pull request as ready for review January 9, 2026 11:08
@Manishakumari-hc Manishakumari-hc requested review from a team as code owners January 9, 2026 11:08
@Manishakumari-hc
mod updates
1d856f9 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc
Merge branch 'main' into manisha/upgrade_aws
d1ebf04
@Manishakumari-hc
go mod update
c385982 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc
Merge branch 'main' into manisha/upgrade_aws
daa55c8
@Manishakumari-hc Manishakumari-hc added backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.21 changes are backported to 1.21 ent backport/1.22 Changes are backported to 1.22 backport/ent/1.22 Changes are backported to 1.22 ent and removed pr/no-backport labels Feb 13, 2026
sreeram77
sreeram77 reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sreeram77 sreeram77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.20 was missed out in the labels. Please use backport/all label.

@Manishakumari-hc
changelog for aws sdk v2 migration
3ce3563 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
sreeram77
sreeram77 suggested changes Feb 13, 2026
View reviewed changes
Comment thread .changelog/23109.txt Outdated
sreeram77
sreeram77 previously requested changes Feb 13, 2026
View reviewed changes
Comment thread command/login/aws.go Outdated
Comment thread agent/connect/ca/provider_vault_auth_aws.go Outdated
Comment thread agent/connect/ca/provider_aws_test.go Outdated
@Manishakumari-hc
review points addressed & improved test coverage
79511c4 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc
changelog indented
4175d0d 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
santoshpulluri
santoshpulluri reviewed Feb 15, 2026
View reviewed changes
Comment thread agent/connect/ca/provider_vault_auth_aws.go
santoshpulluri
santoshpulluri reviewed Feb 15, 2026
View reviewed changes
Comment thread agent/connect/ca/provider_vault_auth_aws.go
santoshpulluri
santoshpulluri reviewed Feb 15, 2026
View reviewed changes
Comment thread agent/connect/ca/provider_vault_auth_aws.go
@Manishakumari-hc
Copy link
Copy Markdown
Collaborator Author

Manishakumari-hc commented Feb 16, 2026

1.20 was missed out in the labels. Please use backport/all label.
No ,this was intentional.I have checked with the release engineer regarding the backport labels.

@Manishakumari-hc
support for IAM,STS,sessiontoken
6487441 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc
comments redefined
d271b4f 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
@Manishakumari-hc
Merge branch 'main' into manisha/upgrade_aws
81befc0
sanikachavan5
sanikachavan5 requested changes Feb 17, 2026
View reviewed changes
Comment thread agent/connect/ca/provider_aws.go
Comment thread agent/connect/ca/provider_aws.go
Comment thread command/login/aws.go
@Manishakumari-hc
support for custom iam endpoint url
77da852 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
sanikachavan5
sanikachavan5 previously approved these changes Feb 17, 2026
View reviewed changes
@Manishakumari-hc Manishakumari-hc requested review from sreeram77 and removed request for sreeram77 February 17, 2026 09:39
@Manishakumari-hc
update awsauth dependency sha
1f6b844 
Signed-off-by: Manisha Kumari <manisha.kumari@hashicorp.com>
sanikachavan5
sanikachavan5 previously approved these changes Feb 17, 2026
View reviewed changes
@Manishakumari-hc Manishakumari-hc dismissed sreeram77’s stale review February 17, 2026 09:55

Addressed the points and replied as comments

sreeram77
sreeram77 suggested changes Feb 17, 2026
View reviewed changes
Comment thread .changelog/23109.txt Outdated
@Manishakumari-hc @sreeram77
Update .changelog/23109.txt
27b3e71 
Co-authored-by: Sreeram Narayanan <sreeram.narayanan@hashicorp.com>
@Manishakumari-hc Manishakumari-hc merged commit c59dbc2 into main Feb 17, 2026
227 of 233 checks passed
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Feb 17, 2026
Merged
@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

hc-github-team-consul-core commented Apr 28, 2026

📣 Hi @Manishakumari-hc! a backport is missing for this PR [23109] for versions [1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santoshpulluri santoshpulluri santoshpulluri left review comments

@sanikachavan5 sanikachavan5 sanikachavan5 left review comments

+1 more reviewer

@sreeram77 sreeram77 sreeram77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Manishakumari-hc Manishakumari-hc

Labels

backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.21 changes are backported to 1.21 ent backport/ent/1.22 Changes are backported to 1.22 ent backport/1.22 Changes are backported to 1.22 pr/dependencies PR specifically updates dependencies of project pr/no-changelog PR does not need a corresponding .changelog entry theme/cli Flags and documentation for the CLI interface theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Manishakumari-hc @hc-github-team-consul-core @sreeram77 @sanikachavan5 @santoshpulluri