fix: remediate scanner security alerts#41
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the cisco-ai-skill-scanner dependency to a pinned patched fork to mitigate a vulnerable LiteLLM pin in the upstream release. The changes include updates to the Dockerfile, pyproject.toml, action.yml, and uv.lock, along with corresponding documentation updates and a new test case to verify handling of the missing dependency. I have provided feedback suggesting the addition of TODO comments for better maintainability and a more idiomatic approach to testing missing modules using sys.modules instead of patching builtins.__import__.
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewThis PR addresses security vulnerabilities (LiteLLM CVE) by:
The changes follow security best practices and the implementation appears sound. Files Reviewed (7 files)
Note: The existing inline comments on Reviewed by minimax-m2.5-20260211 · 327,772 tokens |
Summary
Verification
uv sync --frozen --extra dev --extra cisco --group publishuv run --no-sync ruff check .uv run --no-sync ruff format --check .uv run --no-sync pytest -quv run --no-sync python -m builduv run --no-sync codex-plugin-scanner scan tests/fixtures/good-plugin --format json --cisco-skill-scan on --cisco-policy balancedNotes
mainwas already updated separately to 2 required approvals, which should address the repo-level BranchProtection scorecard finding after rescans