Support open-generic notification handlers with full scenario tests#48
Merged
Conversation
Agent-Logs-Url: https://github.com/hasanxdev/DispatchR/sessions/595ce1db-3d15-4029-9de2-c03cfde0e56d Co-authored-by: hasanxdev <30981174+hasanxdev@users.noreply.github.com>
Agent-Logs-Url: https://github.com/hasanxdev/DispatchR/sessions/595ce1db-3d15-4029-9de2-c03cfde0e56d Co-authored-by: hasanxdev <30981174+hasanxdev@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
hasanxdev
April 17, 2026 11:13
View session
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…d reach 100% coverage Agent-Logs-Url: https://github.com/hasanxdev/DispatchR/sessions/90e47ff8-87c9-4142-88cf-83c7eec466cc Co-authored-by: hasanxdev <30981174+hasanxdev@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds support for resolving and invoking open-generic notification handlers (INotificationHandler<>) via the DispatchR DI registration pipeline, and verifies behavior with unit + integration tests to ensure compatibility with existing concrete handlers.
Changes:
- Updated notification handler registration to correctly register open-generic
INotificationHandler<>implementations. - Added unit test to assert open-generic notification handler DI registration is present.
- Added integration tests + fixtures covering publish scenarios for open-generic + specific handlers (and open-generic-only).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/DispatchR/Configuration/ServiceRegistrator.cs |
Normalizes open-generic notification handler registrations so DI can resolve INotificationHandler<T> for concrete notifications. |
tests/DispatchR.UnitTest/AddDispatchRConfigurationTests.cs |
Adds a unit test ensuring the open-generic INotificationHandler<> registration exists in the service collection. |
tests/DispatchR.IntegrationTest/NotificationTests.cs |
Adds end-to-end tests verifying Publish<T> and Publish(object) invoke both specific and open-generic handlers, plus open-generic-only behavior. |
tests/DispatchR.TestCommon/Fixtures/Notification/OpenGeneric*.cs |
Introduces fixture notifications/handlers and a small execution store used by integration tests to assert handler invocation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/hasanxdev/DispatchR/sessions/9ef271ed-cd29-415a-a675-f6a2be488540 Co-authored-by: hasanxdev <30981174+hasanxdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceRegistrator.RegisterNotificationand simplified dead code to reach 100% coverageGenericAwareNotificationrecord to Sample projectAllNotificationsLogger<TNotification>open-generic handler to Sample project/Notification/DispatchR/Genericendpoint to Program.cs